From: "Christoph Sommer via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Johannes Sixt <j6t@kdbg.org>,
Christoph Sommer <sommer@cms-labs.org>,
Christoph Sommer <sommer@cms-labs.org>
Subject: [PATCH 2/3] gitk: do not set fg/bg color scheme for themed Tk
Date: Mon, 28 Apr 2025 15:56:12 +0000 [thread overview]
Message-ID: <abe92305dcca8ebece332454004b6611ce2efd5a.1745855773.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1909.git.1745855773.gitgitgadget@gmail.com>
From: Christoph Sommer <sommer@cms-labs.org>
Ignore the uicolor preference not just for win32, but also whenever
themed Tk is used. On themed Tk it was frequently only changing the
background of only a few select widgets rather than everything -
and the default uicolor was frequently not the background color that
themed Tk used for its widgets, resulting in a messy looking UI
(mostly light gray, with random widgets surrounded by darker gray borders)
Signed-off-by: Christoph Sommer <sommer@cms-labs.org>
---
gitk-git/gitk | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index 8cb17f39d41..da7507af360 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -11991,6 +11991,12 @@ proc setselbg {c} {
# radiobuttons look bad. This chooses white for selectColor if the
# background color is light, or black if it is dark.
proc setui {c} {
+ global use_ttk
+
+ if {$use_ttk} {
+ return
+ }
+
if {[tk windowingsystem] eq "win32"} { return }
set bg [winfo rgb . $c]
set selc black
--
gitgitgadget
next prev parent reply other threads:[~2025-04-28 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 15:56 [PATCH 0/3] gitk: small quality of life improvements for themed Tk Christoph Sommer via GitGitGadget
2025-04-28 15:56 ` [PATCH 1/3] gitk: fix text wrapping preferences for unthemed tk Christoph Sommer via GitGitGadget
2025-04-28 15:56 ` Christoph Sommer via GitGitGadget [this message]
2025-04-28 15:56 ` [PATCH 3/3] gitk: on themed tk, use uicolor to draw a sash between panes Christoph Sommer via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abe92305dcca8ebece332454004b6611ce2efd5a.1745855773.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=sommer@cms-labs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.