From: Mike Rapoport <rppt@kernel.org>
To: Chunyu Hu <chuhu@redhat.com>
Cc: akpm@linux-foundation.org, david@kernel.org, shuah@kernel.org,
linux-mm@kvack.org, ljs@kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com,
vbabka@suse.cz, surenb@google.com, mhocko@suse.com,
ziy@nvidia.com, baolin.wang@linux.alibaba.com, npache@redhat.com,
ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org,
lance.yang@linux.dev, Li Wang <liwang@redhat.com>
Subject: Re: [PATCH v2 4/5] selftests/mm: split_huge_page_test: skip the test when thp is not available
Date: Mon, 16 Mar 2026 08:29:16 +0200 [thread overview]
Message-ID: <abejPBPP0J2m8j18@kernel.org> (raw)
In-Reply-To: <20260316044335.1390608-5-chuhu@redhat.com>
On Mon, Mar 16, 2026 at 12:43:34PM +0800, Chunyu Hu wrote:
> When thp is not enabled on some kernel config such as realtime kernel, the
> test will report failure. Fix the false positive by skipping the test
> directly when thp is not enabled.
>
> Tested with thp disabled kernel:
> Before The fix:
> # --------------------------------------------------
> # running ./split_huge_page_test /tmp/xfs_dir_Ywup9p
> # --------------------------------------------------
> # TAP version 13
> # Bail out! Reading PMD pagesize failed
> # # Totals: pass:0 fail:0 xfail:0 xpass:0 skip:0 error:0
> # [FAIL]
> not ok 61 split_huge_page_test /tmp/xfs_dir_Ywup9p # exit=1
>
> After the fix:
> # --------------------------------------------------
> # running ./split_huge_page_test /tmp/xfs_dir_YHPUPl
> # --------------------------------------------------
> # TAP version 13
> # 1..0 # SKIP Transparent Hugepages not available
> # [SKIP]
> ok 6 split_huge_page_test /tmp/xfs_dir_YHPUPl # SKIP
>
> Reviewed-by: Lorenzo Stoakes (Oracle) <ljs@kernel.org>
> Reviewed-by: Zi Yan <ziy@nvidia.com>
> CC: Li Wang <liwang@redhat.com>
> Signed-off-by: Chunyu Hu <chuhu@redhat.com>
Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2026-03-16 6:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 4:43 [PATCH v2 0/5] selftests/mm: skip several tests when thp is not available Chunyu Hu
2026-03-16 4:43 ` [PATCH v2 1/5] selftests/mm/guard-regions: skip collapse test when thp not enabled Chunyu Hu
2026-03-16 6:18 ` Mike Rapoport
2026-03-17 6:51 ` Chunyu Hu
2026-03-16 4:43 ` [PATCH v2 2/5] selftests/mm: soft-dirty: skip two tests when thp is not available Chunyu Hu
2026-03-16 6:25 ` Mike Rapoport
2026-03-16 4:43 ` [PATCH v2 3/5] selftests/mm: move write_file helper to vm_util Chunyu Hu
2026-03-16 6:35 ` Mike Rapoport
2026-03-17 9:00 ` Chunyu Hu
2026-03-16 4:43 ` [PATCH v2 4/5] selftests/mm: split_huge_page_test: skip the test when thp is not available Chunyu Hu
2026-03-16 6:29 ` Mike Rapoport [this message]
2026-03-16 14:10 ` David Hildenbrand (Arm)
2026-03-16 4:43 ` [PATCH v2 5/5] selftests/mm: transhuge_stress: skip the test when thp " Chunyu Hu
2026-03-16 6:30 ` Mike Rapoport
2026-03-16 14:11 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abejPBPP0J2m8j18@kernel.org \
--to=rppt@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=chuhu@redhat.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwang@redhat.com \
--cc=ljs@kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=npache@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.