All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Azamat Rakhim <azamatrakhim8@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: rtl8723bs: remove unused rtl8192c_translate_rx_signal_stuff declaration
Date: Mon, 16 Mar 2026 11:33:50 +0300	[thread overview]
Message-ID: <abfAbpPiiOYWF1Ug@stanley.mountain> (raw)
In-Reply-To: <20260313190658.13525-2-azamatrakhim8@gmail.com>

On Sat, Mar 14, 2026 at 12:06:58AM +0500, Azamat Rakhim wrote:
> The function rtl8192c_translate_rx_signal_stuff is declared in rtl8192c_recv.h
> but never defined or called anywhere in the driver
> 
> Signed-off-by: Azamat Rakhim <azamatrakhim8@gmail.com>
> ---
>  drivers/staging/rtl8723bs/include/rtl8192c_recv.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
> index abc7a7c418af..1a04c3454b80 100644
> --- a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
> +++ b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
> @@ -34,6 +34,5 @@ struct phy_stat {
>  /*  Rx smooth factor */
>  #define	Rx_Smooth_Factor (20)
>  
> -void rtl8192c_query_rx_desc_status(union recv_frame *precvframe, struct recv_stat *pdesc);
>  

Need to delete the blank line as well.

regards,
dan carpenter


  reply	other threads:[~2026-03-16  8:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13 19:06 [PATCH 1/2] staging: rtl8723bs: remove unused rtl8192c_query_rx_desc_status declaration Azamat Rakhim
2026-03-13 19:06 ` [PATCH 2/2] staging: rtl8723bs: remove unused rtl8192c_translate_rx_signal_stuff declaration Azamat Rakhim
2026-03-16  8:33   ` Dan Carpenter [this message]
2026-03-13 20:38 ` [PATCH 1/2] staging: rtl8723bs: remove unused rtl8192c_query_rx_desc_status declaration Ethan Tidmore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abfAbpPiiOYWF1Ug@stanley.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=azamatrakhim8@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.