From: Sabrina Dubroca <sd@queasysnail.net>
To: Chuck Lever <cel@kernel.org>
Cc: john.fastabend@gmail.com, kuba@kernel.org,
netdev@vger.kernel.org, kernel-tls-handshake@lists.linux.dev,
Chuck Lever <chuck.lever@oracle.com>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v3 2/8] tls: Factor tls_rx_decrypt_record() helper
Date: Mon, 16 Mar 2026 11:20:07 +0100 [thread overview]
Message-ID: <abfZVw216f_YU-9e@krikkit> (raw)
In-Reply-To: <20260312014804.5083-3-cel@kernel.org>
2026-03-11, 21:47:58 -0400, Chuck Lever wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
>
> recvmsg, read_sock, and splice_read each open-code the
> same sequence: zero-initialize the decrypt arguments, call
> tls_rx_one_record(), and abort the connection on failure.
>
> Extract tls_rx_decrypt_record() so each receive path shares
> a single decrypt-and-abort primitive. Each call site still
> initializes darg.inargs separately, since recvmsg sets zc
> and async between the memset and the decrypt call.
Is there any reason to keep tls_rx_one_record()? You're replacing all
existing callers, and not introducing new users in this series. Seems
like what you want is just move the tls_err_abort() into
tls_rx_one_record().
(I'm not convinced that "abort the connection on every error (decrypt
fail or ENOMEM or whatever)" is right, but that's a separate question)
--
Sabrina
next prev parent reply other threads:[~2026-03-16 10:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 1:47 [PATCH v3 0/8] TLS read_sock performance scalability Chuck Lever
2026-03-12 1:47 ` [PATCH v3 1/8] tls: Factor tls_decrypt_async_drain() from recvmsg Chuck Lever
2026-03-12 4:34 ` Alistair Francis
2026-03-16 10:13 ` Sabrina Dubroca
2026-03-12 1:47 ` [PATCH v3 2/8] tls: Factor tls_rx_decrypt_record() helper Chuck Lever
2026-03-12 4:35 ` Alistair Francis
2026-03-16 10:20 ` Sabrina Dubroca [this message]
2026-03-17 7:06 ` Hannes Reinecke
2026-03-12 1:47 ` [PATCH v3 3/8] tls: Fix dangling skb pointer in tls_sw_read_sock() Chuck Lever
2026-03-12 1:48 ` [PATCH v3 4/8] tls: Factor tls_strp_msg_release() from tls_strp_msg_done() Chuck Lever
2026-03-12 1:48 ` [PATCH v3 5/8] tls: Suppress spurious saved_data_ready on all receive paths Chuck Lever
2026-03-12 1:48 ` [PATCH v3 6/8] tls: Flush backlog before tls_rx_rec_wait in read_sock Chuck Lever
2026-03-16 17:17 ` Sabrina Dubroca
2026-03-12 1:48 ` [PATCH v3 7/8] tls: Restructure tls_sw_read_sock() into submit/deliver phases Chuck Lever
2026-03-12 1:48 ` [PATCH v3 8/8] tls: Enable batch async decryption in read_sock Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abfZVw216f_YU-9e@krikkit \
--to=sd@queasysnail.net \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=hare@suse.de \
--cc=john.fastabend@gmail.com \
--cc=kernel-tls-handshake@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.