From: Peter Xu <peterx@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: Roman Kiryanov <rkir@google.com>,
qemu-devel@nongnu.org, whollins@google.com, jansene@google.com,
jpcottin@google.com
Subject: Re: [PATCH v3] vmstate: validate VMStateDescription::fields upon registration
Date: Mon, 16 Mar 2026 11:42:28 -0400 [thread overview]
Message-ID: <abgk5IYccjoS6hkQ@x1.local> (raw)
In-Reply-To: <87341zsvmc.fsf@suse.de>
On Mon, Mar 16, 2026 at 11:21:31AM -0300, Fabiano Rosas wrote:
> Looks like we'll also need to fix some stubs that define empty vmsds:
>
> qemu-system-mips64: ../migration/savevm.c:864: void vmstate_check(const
> VMStateDescription *): Assertion `field || vmsd->unmigratable' failed.
>
> Maybe something like the following. Peter, what do you think?
Yep, sounds ok.
--
Peter Xu
next prev parent reply other threads:[~2026-03-16 15:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 23:35 [PATCH v3] vmstate: validate VMStateDescription::fields upon registration Roman Kiryanov
2026-03-16 14:21 ` Fabiano Rosas
2026-03-16 15:42 ` Peter Xu [this message]
2026-03-16 15:57 ` Peter Maydell
2026-03-16 16:23 ` Philippe Mathieu-Daudé
2026-03-17 18:50 ` Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abgk5IYccjoS6hkQ@x1.local \
--to=peterx@redhat.com \
--cc=farosas@suse.de \
--cc=jansene@google.com \
--cc=jpcottin@google.com \
--cc=qemu-devel@nongnu.org \
--cc=rkir@google.com \
--cc=whollins@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.