From: Niklas Cassel <cassel@kernel.org>
To: Christian Bruel <christian.bruel@foss.st.com>
Cc: "Koichiro Den" <den@valinux.co.jp>,
"Bjorn Helgaas" <helgaas@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Frank Li" <Frank.Li@nxp.com>, "Kees Cook" <kees@kernel.org>,
"Shin'ichiro Kawasaki" <shinichiro.kawasaki@wdc.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Bhanu Seshu Kumar Valluri" <bhanuseshukumar@gmail.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: endpoint: pci-epf-test: Roll back BAR mapping when subrange setup fails
Date: Tue, 17 Mar 2026 11:12:43 +0100 [thread overview]
Message-ID: <abkpFpD3cM_cI_nB@ryzen> (raw)
In-Reply-To: <c9278648-1ec1-419e-89ee-0868a4c7c86d@foss.st.com>
On Tue, Mar 17, 2026 at 11:01:28AM +0100, Christian Bruel wrote:
>
>
> >
> > So we will need to add a SKIP ENOSPC case in TEST_F(pci_ep_bar,
> > BAR_SUBRANGE_TEST)
> >
> Re-checking this, no need for ENOSPC test. The real condition would be
> EBUSY. Which can be handled nicely in a stm32 ep_map_addr helper.
Are you sure that it returns EBUSY and not ENOSPC?
I would have expected the error to be ENOSPC when there are no free inbound
window:
https://github.com/torvalds/linux/blob/v7.0-rc4/drivers/pci/controller/dwc/pcie-designware-ep.c#L307-L312
I think a SKIP ENOSPC case in TEST_F(pci_ep_bar, BAR_SUBRANGE_TEST) in
a better solution than modifying a STM32 specific helper.
Because the former will ensure that we skip/handle this issue on all SoCs
with few inbound windows, not only on STM32.
Kind regards,
Niklas
next prev parent reply other threads:[~2026-03-17 10:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 14:02 [PATCH] PCI: endpoint: pci-epf-test: Roll back BAR mapping when subrange setup fails Koichiro Den
2026-03-16 14:36 ` Koichiro Den
2026-03-16 14:41 ` Koichiro Den
2026-03-16 16:19 ` Niklas Cassel
2026-03-17 2:57 ` Koichiro Den
2026-03-17 3:27 ` Manivannan Sadhasivam
2026-03-17 9:13 ` Christian Bruel
2026-03-17 9:24 ` Niklas Cassel
2026-03-17 9:55 ` Christian Bruel
2026-03-17 10:01 ` Christian Bruel
2026-03-17 10:12 ` Niklas Cassel [this message]
2026-03-17 10:29 ` Christian Bruel
2026-03-17 10:46 ` Niklas Cassel
2026-03-17 15:14 ` Koichiro Den
2026-03-18 8:02 ` Christian Bruel
2026-03-18 8:35 ` Christian Bruel
2026-03-18 8:58 ` Niklas Cassel
2026-03-18 12:58 ` Christian Bruel
2026-03-17 15:17 ` Koichiro Den
2026-03-17 9:59 ` Manivannan Sadhasivam
2026-03-17 10:02 ` Christian Bruel
2026-03-17 10:05 ` Niklas Cassel
2026-03-17 15:27 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abkpFpD3cM_cI_nB@ryzen \
--to=cassel@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhanuseshukumar@gmail.com \
--cc=christian.bruel@foss.st.com \
--cc=den@valinux.co.jp \
--cc=helgaas@kernel.org \
--cc=kees@kernel.org \
--cc=kishon@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mani@kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.