All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Joseph Salisbury <joseph.salisbury@oracle.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [External] : [PATCH] Input: sentelic: fix comment typo
Date: Tue, 17 Mar 2026 22:43:51 -0700	[thread overview]
Message-ID: <abo7FVLq3qUzxkee@google.com> (raw)
In-Reply-To: <e35b4f27-53c1-41c2-a321-42a34ade9839@oracle.com>

Hi Joseph,

On Mon, Mar 16, 2026 at 07:48:31PM -0400, Joseph Salisbury wrote:
> 
> 
> On 3/16/26 2:12 PM, Joseph Salisbury wrote:
> > The file contains a spelling error in a source comment (formating).
> > 
> > Typos in comments reduce readability and make text searches less reliable
> > for developers and maintainers.
> > 
> > Replace 'formating' with 'formatting' in the affected comment. This is a
> > comment-only cleanup and does not change behavior.
> > 
> > Fixes: fc69f4a6af49 ("Input: add new driver for Sentelic Finger Sensing Pad")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Joseph Salisbury <joseph.salisbury@oracle.com>
> > ---
> >   drivers/input/mouse/sentelic.h | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/input/mouse/sentelic.h b/drivers/input/mouse/sentelic.h
> > index 02cac0e7ad63..9ba3631e3d0f 100644
> > --- a/drivers/input/mouse/sentelic.h
> > +++ b/drivers/input/mouse/sentelic.h
> > @@ -60,7 +60,7 @@
> >   #define	FSP_REG_SN1		(0x41)
> >   #define	FSP_REG_SN2		(0x42)
> > -/* Finger-sensing Pad packet formating related definitions */
> > +/* Finger-sensing Pad packet formatting related definitions */
> >   /* absolute packet type */
> >   #define	FSP_PKT_TYPE_NORMAL	(0x00)
> I inadvertently added Fixes: and Cc: stable tags.  If possible, please
> remove them as they are not appropriate for fixes to misspellings in code
> comments.  If it's not possible to remove them, I can send a v2.
> 

Sorry I did not receive the original patch but even with the typo fixed
this comment needs more work to improve readability.

Thanks.

-- 
Dmitry

  reply	other threads:[~2026-03-18  5:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-16 18:12 [PATCH] Input: sentelic: fix comment typo Joseph Salisbury
2026-03-16 23:48 ` [External] : " Joseph Salisbury
2026-03-18  5:43   ` Dmitry Torokhov [this message]
2026-03-18 16:34     ` Joseph Salisbury

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abo7FVLq3qUzxkee@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=joseph.salisbury@oracle.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.