From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from orbyte.nwl.cc (orbyte.nwl.cc [151.80.46.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1963633067F for ; Wed, 18 Mar 2026 10:46:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=151.80.46.58 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773830785; cv=none; b=qLngSyWCC7NyEmufEwHPiZJyG01cjTLsW2PlOK1+L8MPhE0fzUg7HfOEbPuJAX475tf7JpRJ3bFeqyBh7sBKIZuF7CZAQB2O5Ufo4zH7QIAY+5lzdPMXJWWfvwKSD9eweZrA/HVcSLbOPOpVNGSlc0XlS8Io7Cmg4N5v4jouWgs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773830785; c=relaxed/simple; bh=nYOuhVMgqvrFPv6ZEw6DJjiRI77Taopjxl1hK/BbePY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=E6MnPIYKEFG1Bn8B4vH8I0fXj8T+ic3hsQMLavZFQ2p7JKkgYKFDMNL0I66dgdyBXuMngilI50KjTAs0SnDifZjAJSZXnUKO0y1wN8zPT1Q5e0YAPGMbGPrc6fwUwSdzslIGbVrISNLGXFYe+30Je3/FXW2b/iMTvWZiKXMhEj4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nwl.cc; spf=pass smtp.mailfrom=nwl.cc; dkim=pass (2048-bit key) header.d=nwl.cc header.i=@nwl.cc header.b=URZwsolQ; arc=none smtp.client-ip=151.80.46.58 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nwl.cc Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nwl.cc Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nwl.cc header.i=@nwl.cc header.b="URZwsolQ" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nwl.cc; s=mail2022; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=95CqMctSKPBz4KspsXYe8DLCLQCWVmJd+ei8hZApC0k=; b=URZwsolQJUFetqLm7n2kpvG/Ok +zh69dkFQxssN9jSHKo8J1jMi1apPL03zQ74DSmu96n9eVT6ZgbRd7GB/cabin5VRPUDvPW84HiR0 aIEb3bZZFvJcMZnnrnE1rvMiL5xUO6dWQ98rmaUbvcRQn14o7oM6XaET20EIN0C0rSB0FmQrGPE4Z 2/R9ZvYP54aXuK8/uxHRLIhjdb5IkXrmOHgZUtqw00oPR69UO9UzP63t11SNYVkn62D6rNSx1ojmT in9RclAHfWMuqaM93qSd/OejuT0RqHy+utkooUaDS4BsYNl9qW+pLoJFHBeplQw0wnSXX9B5jUrS3 A4w47kHA==; Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.98.2) (envelope-from ) id 1w2oPm-000000006Qp-2T0r; Wed, 18 Mar 2026 11:46:14 +0100 Date: Wed, 18 Mar 2026 11:46:14 +0100 From: Phil Sutter To: chlorodose Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH] src: Export nftnl_set_clone symbol Message-ID: Mail-Followup-To: Phil Sutter , chlorodose , netfilter-devel@vger.kernel.org References: <20260318025651.151116-1-chlorodose@gmail.com> Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260318025651.151116-1-chlorodose@gmail.com> Hi chlorodose, On Wed, Mar 18, 2026 at 10:56:51AM +0800, chlorodose wrote: > Seems that nftnl_set_clone is forgot to be exported, we add it back. > > Signed-off-by: chlorodose > --- > src/set.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/set.c b/src/set.c > index 54674bc..e5e51b6 100644 > --- a/src/set.c > +++ b/src/set.c > @@ -360,6 +360,7 @@ uint64_t nftnl_set_get_u64(const struct nftnl_set *s, uint16_t attr) > return val ? *val : 0; > } > > +EXPORT_SYMBOL(nftnl_set_clone); > struct nftnl_set *nftnl_set_clone(const struct nftnl_set *set) > { > struct nftnl_set *newset; Don't you also have to add it to src/libnftnl.map? How did you test this patch? Looking at the function itself, I fear the code is not correct anymore. E.g., it does not clone expr_list or user.data. If I was to decide, I'd rather drop it entirely instead of polishing it up. What's your use-case? Cheers, Phil