From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EC61103E168 for ; Wed, 18 Mar 2026 12:32:46 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w2q4M-0000CA-5Z; Wed, 18 Mar 2026 08:32:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2q4K-0000BY-Pm for qemu-devel@nongnu.org; Wed, 18 Mar 2026 08:32:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w2q4I-0008Co-OX for qemu-devel@nongnu.org; Wed, 18 Mar 2026 08:32:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773837128; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SmWqYyvWGPzZaj8cYH/kOi4nse4MO/7kCsXH/A1b52w=; b=dIoP1w6hAeIsGmYicUMCimQY+JeJQJz4SqnC+YBDdu0/Kx0LZjq0ZDRHNTN+z/WO2fYZK3 2PIA2b7Jb6l7wKnd7BGrvlb4rep7YGRZfmsiksqxNkkuPOxQJ1F96AnMWerfc773O0i2Mz gc3JzSk15Gp/ClDgkoaNGBAJUNH9SZo= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-639-sJYxzZnhM9S2SGeu7nq4Cw-1; Wed, 18 Mar 2026 08:32:05 -0400 X-MC-Unique: sJYxzZnhM9S2SGeu7nq4Cw-1 X-Mimecast-MFC-AGG-ID: sJYxzZnhM9S2SGeu7nq4Cw_1773837124 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3534519560A1; Wed, 18 Mar 2026 12:32:04 +0000 (UTC) Received: from redhat.com (unknown [10.44.33.194]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0945D1955F19; Wed, 18 Mar 2026 12:32:01 +0000 (UTC) Date: Wed, 18 Mar 2026 12:31:57 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Paolo Bonzini Cc: Manos Pitsidianakis , qemu-devel@nongnu.org, Peter Maydell Subject: Re: [PATCH] rust: suggest passing --locked to "cargo install" Message-ID: References: <20260318082113.1127992-1-pbonzini@redhat.com> <980ab0ed-d009-4e7b-a199-8edc8379e676@redhat.com> <2c5efc3d-8e36-4ca4-8593-9cf9e64c7982@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2c5efc3d-8e36-4ca4-8593-9cf9e64c7982@redhat.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Mar 18, 2026 at 01:27:35PM +0100, Paolo Bonzini wrote: > On 3/18/26 10:43, Daniel P. Berrangé wrote: > > On Wed, Mar 18, 2026 at 11:32:59AM +0200, Manos Pitsidianakis wrote: > > > > The "cargo install bindgen-cli" command does not use QEMU's Cargo.lock, > > > > > > So what does `--locked` do here? As per `--help`: "--locked Assert > > > that `Cargo.lock` will remain unchanged" What Cargo.lock does it not > > > change? > > > > --locked ensures that cargo honours the Cargo.lock from the bindgen.git > > repo, instead of pulling in arbitrarily newer dependencies. The > > fixed versions of deps in bindgen's Cargo.lock are still compatible > > with edition2021, but the latest deps are only compatible with edition2024, > > and we need edition2021 > > ... and that does mean that sooner or later bindgen might update to a > version that requires 2024 and we're out of luck. So we could indeed add > "--version" too, just like Manos suggested. (Separately because this issue > was breaking the build and Peter speed-runned the merging). > > That said, support for 22.04 is going away soon and at that point "cargo > install" will only be needed for the nightly job. So it's not super > necessary, either. Indeed, as soon as this pending release of QEMU is finalized, we can bump the min Ubuntu to 24.04 With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|