From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: andrew@codeconstruct.com.au, avifishman70@gmail.com,
tmaimon77@gmail.com, tali.perry1@gmail.com, srini@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
venture@google.com, yuenn@google.com, benjaminfair@google.com,
jserv@ccns.ncku.edu.tw, eleanor15x@gmail.com,
linux-arm-kernel@lists.infradead.org, openbmc@lists.ozlabs.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: nvmem: add nuvoton,npcm750-otp
Date: Thu, 19 Mar 2026 04:24:56 +0800 [thread overview]
Message-ID: <absKGJbrWX5xtPX3@google.com> (raw)
In-Reply-To: <228943f2-8f1a-4da7-8663-7f17f5e2f21c@kernel.org>
Hi Krzysztof,
On Wed, Mar 18, 2026 at 09:17:19PM +0100, Krzysztof Kozlowski wrote:
> On 18/03/2026 20:35, Kuan-Wei Chiu wrote:
> > +maintainers:
> > + - Kuan-Wei Chiu <visitorckw@gmail.com>
> > +
> > +allOf:
> > + - $ref: nvmem.yaml#
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - nuvoton,npcm750-key-storage
> > + - nuvoton,npcm750-fuse-array
>
> Your driver says these are exactly the same devices, so you got only one
> compatible. Otherwise explain in commit msg why these are different
> (current message speaks about purpose, but is not what is needed here).
>
Thanks for the prompt review.
I will drop the content-specific compatible strings and unify them into
a single "nuvoton,npcm750-otp" in the upcoming v2 series.
Regards,
Kuan-Wei
next prev parent reply other threads:[~2026-03-18 20:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 19:35 [PATCH 0/3] nvmem: Add Nuvoton NPCM OTP driver Kuan-Wei Chiu
2026-03-18 19:35 ` [PATCH 1/3] dt-bindings: nvmem: add nuvoton,npcm750-otp Kuan-Wei Chiu
2026-03-18 20:17 ` Krzysztof Kozlowski
2026-03-18 20:24 ` Kuan-Wei Chiu [this message]
2026-03-18 19:35 ` [PATCH 2/3] nvmem: npcm-otp: Add Nuvoton NPCM OTP driver Kuan-Wei Chiu
2026-03-19 10:57 ` Tomer Maimon
2026-03-19 16:17 ` Kuan-Wei Chiu
2026-03-18 19:35 ` [PATCH 3/3] ARM: dts: nuvoton: Add OTP nodes for NPCM7xx Kuan-Wei Chiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=absKGJbrWX5xtPX3@google.com \
--to=visitorckw@gmail.com \
--cc=andrew@codeconstruct.com.au \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eleanor15x@gmail.com \
--cc=jserv@ccns.ncku.edu.tw \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh@kernel.org \
--cc=srini@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.