All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <andersson@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
	 Rob Herring <robh@kernel.org>,
	Saravana Kannan <saravanak@kernel.org>,
	 "Rafael J . Wysocki" <rafael@kernel.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	 Ilia Lin <ilia.lin@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	 Magnus Damm <magnus.damm@gmail.com>,
	devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
	 linux-arm-msm@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/7] soc: qcom: pd-mapper: Convert to of_machine_get_match()
Date: Wed, 18 Mar 2026 22:36:00 -0500	[thread overview]
Message-ID: <abtvGIWzG-UxN1GD@baldur> (raw)
In-Reply-To: <0d23a449e62ac85f04ff07bc2758efbaa709c9d1.1772468323.git.geert+renesas@glider.be>

On Mon, Mar 02, 2026 at 05:29:10PM +0100, Geert Uytterhoeven wrote:
> Use the of_machine_get_match() helper instead of open-coding the same
> operation.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Bjorn Andersson <andersson@kernel.org>

Regards,
Bjorn

> ---
> Compile-tested only.
> ---
>  drivers/soc/qcom/qcom_pd_mapper.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/soc/qcom/qcom_pd_mapper.c b/drivers/soc/qcom/qcom_pd_mapper.c
> index dc10bc859ff4170c..8a1a18f8c859496f 100644
> --- a/drivers/soc/qcom/qcom_pd_mapper.c
> +++ b/drivers/soc/qcom/qcom_pd_mapper.c
> @@ -615,15 +615,9 @@ static struct qcom_pdm_data *qcom_pdm_start(void)
>  	const struct qcom_pdm_domain_data * const *domains;
>  	const struct of_device_id *match;
>  	struct qcom_pdm_data *data;
> -	struct device_node *root;
>  	int ret, i;
>  
> -	root = of_find_node_by_path("/");
> -	if (!root)
> -		return ERR_PTR(-ENODEV);
> -
> -	match = of_match_node(qcom_pdm_domains, root);
> -	of_node_put(root);
> +	match = of_machine_get_match(qcom_pdm_domains);
>  	if (!match) {
>  		pr_notice("PDM: no support for the platform, userspace daemon might be required.\n");
>  		return ERR_PTR(-ENODEV);
> -- 
> 2.43.0
> 

  parent reply	other threads:[~2026-03-19  3:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02 16:29 [PATCH 0/7] of: Add and use of_machine_get_match() helper Geert Uytterhoeven
2026-03-02 16:29 ` [PATCH 1/7] of: Add " Geert Uytterhoeven
2026-03-02 16:29 ` [PATCH 2/7] of: Convert to of_machine_get_match() Geert Uytterhoeven
2026-03-02 16:29 ` [PATCH 3/7] cpufreq: airoha: " Geert Uytterhoeven
2026-03-02 16:29 ` [PATCH 4/7] cpufreq: qcom-nvmem: " Geert Uytterhoeven
2026-03-02 16:29 ` [PATCH 5/7] cpufreq: ti-cpufreq: " Geert Uytterhoeven
2026-03-02 16:29 ` [PATCH 6/7] soc: qcom: pd-mapper: " Geert Uytterhoeven
2026-03-03 10:07   ` Konrad Dybcio
2026-03-19  3:36   ` Bjorn Andersson [this message]
2026-03-02 16:29 ` [PATCH 7/7] soc: renesas: " Geert Uytterhoeven
2026-03-13 21:59   ` Rob Herring
2026-03-25 16:35     ` Geert Uytterhoeven
2026-05-07  9:21       ` Geert Uytterhoeven
2026-03-03  4:31 ` [PATCH 0/7] of: Add and use of_machine_get_match() helper Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abtvGIWzG-UxN1GD@baldur \
    --to=andersson@kernel.org \
    --cc=bartosz.golaszewski@oss.qualcomm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=ilia.lin@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=saravanak@kernel.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.