From: Dan Carpenter <dan.carpenter@linaro.org>
To: Oskar Ray-Frayssinet <rayfraytech@gmail.com>
Cc: gregkh@linuxfoundation.org, straube.linux@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2] staging: rtl8723bs: remove unnecessary braces in single statement blocks
Date: Thu, 19 Mar 2026 12:11:24 +0300 [thread overview]
Message-ID: <abu9vH0uNUkGFNB7@stanley.mountain> (raw)
In-Reply-To: <20260318214117.10285-1-rayfraytech@gmail.com>
On Wed, Mar 18, 2026 at 10:41:17PM +0100, Oskar Ray-Frayssinet wrote:
> @@ -403,10 +385,8 @@ static u8 halbtc8723b2ant_ActionAlgorithm(struct btc_coexist *pBtCoexist)
> pBtLinkInfo->bPanExist &&
> pBtLinkInfo->bA2dpExist
> ) {
> - if (bBtHsOn) {
> - } else {
> + if (bBtHsOn)
> algorithm = BT_8723B_2ANT_COEX_ALGO_PANEDR_HID;
> - }
The patch introduces a bug here.
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> index af6cdda8238d..f4b2854bada7 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> @@ -25,9 +25,8 @@ static u8 _is_fw_read_cmd_down(struct adapter *padapter, u8 msgbox_num)
>
> do {
> valid = rtw_read8(padapter, REG_HMETFR) & BIT(msgbox_num);
> - if (0 == valid) {
> + if (valid == 0)
Don't do unrelated changes.
> read_down = true;
> - }
> } while ((!read_down) && (retry_cnts--));
>
regards,
dan carpenter
prev parent reply other threads:[~2026-03-19 9:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 21:41 [PATCH v2] staging: rtl8723bs: remove unnecessary braces in single statement blocks Oskar Ray-Frayssinet
2026-03-19 9:11 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abu9vH0uNUkGFNB7@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lkp@intel.com \
--cc=rayfraytech@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.