All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 7/8] meson: compile compatibility sources separately
Date: Thu, 19 Mar 2026 06:32:31 +0100	[thread overview]
Message-ID: <abuKb8OmcgDY1vMy@pks.im> (raw)
In-Reply-To: <6b8e418a-cac4-40d0-8f1e-762b15911227@app.fastmail.com>

On Tue, Mar 17, 2026 at 04:38:31PM +0100, Kristoffer Haugsbakk wrote:
> On Tue, Mar 10, 2026, at 18:52, Patrick Steinhardt wrote:
> > In the next commit we're about to introduce a precompiled header for
> > "git-compat-util.h". The consequence of this change is that we'll
> > implicitly include that header for every compilation unit that uses the
> > precompiled headers.
> >
> > This is okay for our "normal" library sources and our builtins. But some
> > of our compatibility sources do not include the header on purpose, and
> > doing so would cause compileir errors.
> 
> s/compileir/compiler/ (or /compilation)
> 
> >
> > Prepare for this change by splitting out compatibility sources into
> > their static library. Like this we can selectively enable precompiled
> 
> s/Like this/Like this,/ ?

Yup, both of these make sense. Thanks!

Patric

  reply	other threads:[~2026-03-19  5:32 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-10 17:52 [PATCH 0/8] Some build system improvements Patrick Steinhardt
2026-03-10 17:52 ` [PATCH 1/8] Introduce new "tools/" directory Patrick Steinhardt
2026-03-10 17:52 ` [PATCH 2/8] contrib: move "coccinelle/" directory into "tools/" Patrick Steinhardt
2026-03-10 17:52 ` [PATCH 3/8] contrib: move "coverage-diff.sh" script " Patrick Steinhardt
2026-03-10 17:52 ` [PATCH 4/8] contrib: move "update-unicode.sh" " Patrick Steinhardt
2026-03-10 17:52 ` [PATCH 5/8] builds: move build scripts " Patrick Steinhardt
2026-03-10 17:52 ` [PATCH 6/8] git-compat-util.h: move warning infra to prepare for PCHs Patrick Steinhardt
2026-03-10 17:52 ` [PATCH 7/8] meson: compile compatibility sources separately Patrick Steinhardt
2026-03-11 14:32   ` Phillip Wood
2026-03-11 14:56     ` Phillip Wood
2026-03-11 23:27       ` SZEDER Gábor
2026-03-12  6:21         ` Patrick Steinhardt
2026-03-13 10:33           ` Phillip Wood
2026-03-16  8:09             ` Patrick Steinhardt
2026-04-10 15:17           ` SZEDER Gábor
2026-03-12  6:22       ` Patrick Steinhardt
2026-03-13 10:33         ` Phillip Wood
2026-03-16  8:09           ` Patrick Steinhardt
2026-03-16 10:52             ` Phillip Wood
2026-03-17 15:38   ` Kristoffer Haugsbakk
2026-03-19  5:32     ` Patrick Steinhardt [this message]
2026-03-10 17:52 ` [PATCH 8/8] meson: precompile "git-compat-util.h" Patrick Steinhardt
2026-03-11 14:32   ` Phillip Wood
2026-03-12  6:21     ` Patrick Steinhardt
2026-03-10 18:23 ` [PATCH 0/8] Some build system improvements Junio C Hamano
2026-03-11  7:32   ` Patrick Steinhardt
2026-03-13 22:21 ` Junio C Hamano
2026-03-16  8:09   ` Patrick Steinhardt
2026-03-16 10:07 ` [PATCH v2 " Patrick Steinhardt
2026-03-16 10:07   ` [PATCH v2 1/8] Introduce new "tools/" directory Patrick Steinhardt
2026-03-16 10:07   ` [PATCH v2 2/8] contrib: move "coccinelle/" directory into "tools/" Patrick Steinhardt
2026-03-16 10:07   ` [PATCH v2 3/8] contrib: move "coverage-diff.sh" script " Patrick Steinhardt
2026-03-16 10:07   ` [PATCH v2 4/8] contrib: move "update-unicode.sh" " Patrick Steinhardt
2026-03-16 10:08   ` [PATCH v2 5/8] builds: move build scripts " Patrick Steinhardt
2026-03-16 10:08   ` [PATCH v2 6/8] git-compat-util.h: move warning infra to prepare for PCHs Patrick Steinhardt
2026-03-16 10:08   ` [PATCH v2 7/8] meson: compile compatibility sources separately Patrick Steinhardt
2026-03-16 10:08   ` [PATCH v2 8/8] meson: precompile "git-compat-util.h" Patrick Steinhardt
2026-03-16 10:54   ` [PATCH v2 0/8] Some build system improvements Phillip Wood
2026-03-19  5:33 ` [PATCH v3 " Patrick Steinhardt
2026-03-19  5:33   ` [PATCH v3 1/8] Introduce new "tools/" directory Patrick Steinhardt
2026-03-19  5:33   ` [PATCH v3 2/8] contrib: move "coccinelle/" directory into "tools/" Patrick Steinhardt
2026-03-19  5:33   ` [PATCH v3 3/8] contrib: move "coverage-diff.sh" script " Patrick Steinhardt
2026-03-20 12:15     ` Toon Claes
2026-03-19  5:33   ` [PATCH v3 4/8] contrib: move "update-unicode.sh" " Patrick Steinhardt
2026-03-19  5:33   ` [PATCH v3 5/8] builds: move build scripts " Patrick Steinhardt
2026-03-19  5:33   ` [PATCH v3 6/8] git-compat-util.h: move warning infra to prepare for PCHs Patrick Steinhardt
2026-03-20 12:34     ` Toon Claes
2026-03-19  5:33   ` [PATCH v3 7/8] meson: compile compatibility sources separately Patrick Steinhardt
2026-03-19  5:33   ` [PATCH v3 8/8] meson: precompile "git-compat-util.h" Patrick Steinhardt
2026-03-20 12:37     ` Toon Claes
2026-04-10 15:36     ` SZEDER Gábor
2026-04-10 15:46       ` Phillip Wood
2026-04-10 16:05         ` SZEDER Gábor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abuKb8OmcgDY1vMy@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=kristofferhaugsbakk@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.