Re: [PATCH] vfio: selftests: Build tests on aarch64

[David Matlack <dmatlack@google.com>]

On 2026-03-17 04:25 PM, Ted Logan wrote:
> Also build vfio self-tests on aarch64 variants, in addition to arm64 and

s/self-tests/selftests/

> x86_64.

This could be worded better to clarify that this is about fixing the
VFIO selftests to allow native builds on arm64 host platforms.

> 
> Reported-by: Matt Evans <mattev@meta.com>
> Closes: https://lore.kernel.org/all/e51b4ff2-13c4-47d4-b781-3dcbd740d274@meta.com/

Please also add a fixes tag, since it was not the intent of the original
commit was to disallow native arm64 builds.

  Fixes: a55d4bbbe644 ("vfio: selftests: only build tests on arm64 and x86_64")

> ---
> Signed-off-by: Ted Logan <tedlogan@fb.com>
> ---
>  tools/testing/selftests/vfio/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/vfio/Makefile b/tools/testing/selftests/vfio/Makefile
> index 8e90e409e91d..98bc8d6271a4 100644
> --- a/tools/testing/selftests/vfio/Makefile
> +++ b/tools/testing/selftests/vfio/Makefile
> @@ -1,4 +1,4 @@
> -ARCH ?= $(shell uname -m)
> +ARCH ?= $(shell uname -m | sed -e 's/aarch64.*/arm64/')

Perhaps we can just include tools/scripts/Makefile.arch to avoid having
to maintain yet another "uname -m" translation?

This would make it harder to prevent aarch64_be though, which Alex
indicated we might want to do.

>  
>  ifeq (,$(filter $(ARCH),arm64 x86_64))
>  # Do nothing on unsupported architectures
> 
> ---
> base-commit: 96ca4caf9066f5ebd35b561a521af588a8eb0215
> change-id: 20260317-vfio-selftests-aarch64-636abf0f7674
> 
> Best regards,
> -- 
> Ted Logan <tedlogan@fb.com>
>