Re: [PATCH v3 2/2] mm/memblock: Add reserve_mem debugfs info

[Mike Rapoport <rppt@kernel.org>]

On Thu, Mar 19, 2026 at 02:14:00PM -0300, Guilherme G. Piccoli wrote:
> On 19/03/2026 13:34, Mike Rapoport wrote:
> > [...]
> >>  {
> >> -	struct dentry *root = debugfs_create_dir("memblock", NULL);
> >> -
> >> -	debugfs_create_file("memory", 0444, root,
> >> -			    &memblock.memory, &memblock_debug_fops);
> >> -	debugfs_create_file("reserved", 0444, root,
> >> -			    &memblock.reserved, &memblock_debug_fops);
> >>  #ifdef CONFIG_HAVE_MEMBLOCK_PHYS_MAP
> >>  	debugfs_create_file("physmem", 0444, root, &physmem,
> >>  			    &memblock_debug_fops);
> >>  #endif
> >> +	debugfs_create_file("memory", 0444, root,
> >> +			    &memblock.memory, &memblock_debug_fops);
> >> +	debugfs_create_file("reserved", 0444, root,
> >> +			    &memblock.reserved, &memblock_debug_fops);
> > 
> > No need to move these after PHYS_MAP attribute
> > 
> 
> OK, your call, will change it in the respin as well.
> Thanks,

That's actually more of a rule in the kernel: don't introduce unnecessary
changes :)
  
> Guilherme
> 

-- 
Sincerely yours,
Mike.