From: Chunyu Hu <chuhu@redhat.com>
To: "Lorenzo Stoakes (Oracle)" <ljs@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
david@kernel.org, shuah@kernel.org, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com,
vbabka@suse.cz, rppt@kernel.org, surenb@google.com,
mhocko@suse.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com,
npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com,
baohua@kernel.org, lance.yang@linux.dev
Subject: Re: [PATCH v3 0/5] selftests/mm: skip several tests when thp is not available
Date: Thu, 19 Mar 2026 23:05:43 +0800 [thread overview]
Message-ID: <abwQx-P3pfyJ14ve@gmail.com> (raw)
In-Reply-To: <893e70b9-1ed2-419b-9079-5b397b2cec54@lucifer.local>
On Wed, Mar 18, 2026 at 11:32:10AM +0000, Lorenzo Stoakes (Oracle) wrote:
> On Wed, Mar 18, 2026 at 05:22:40PM +0800, Chunyu Hu wrote:
> > For question one. In guard-region test, collapse tests are for checking
> > collapse is denied when operating on guard region, not for checking
> > madvise(MADV_COLLAPSE) will fail when thp is setup to 'never with sysfs,
>
> No, if thp is set to never, madvise(MADV_COLLAPSE) still succeeds. This is a
> source of confusion for many :)
You are right. Thanks for correcting me.
>
> > result is same, but it's a different test. Maybe we don't have strong
> > interest to test when thp is set to 'never' in this collapse test.
> > Do you perfer we let it run when thp is setup with 'never'?
>
> Yes because it should still function then :)
Sure. Let me send a v4 to change to thp_available().
>
> Cheers, Lorenzo
>
next prev parent reply other threads:[~2026-03-19 15:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 9:44 [PATCH v3 0/5] selftests/mm: skip several tests when thp is not available Chunyu Hu
2026-03-17 9:44 ` [PATCH v3 1/5] selftests/mm/guard-regions: skip collapse test when thp not enabled Chunyu Hu
2026-03-17 9:44 ` [PATCH v3 2/5] selftests/mm: soft-dirty: skip two tests when thp is not available Chunyu Hu
2026-03-17 9:44 ` [PATCH v3 3/5] selftests/mm: move write_file helper to vm_util Chunyu Hu
2026-03-17 11:00 ` David Hildenbrand (Arm)
2026-03-17 11:06 ` Lorenzo Stoakes (Oracle)
2026-03-17 9:44 ` [PATCH v3 4/5] selftests/mm: split_huge_page_test: skip the test when thp is not available Chunyu Hu
2026-03-17 9:44 ` [PATCH v3 5/5] selftests/mm: transhuge_stress: skip the test when thp " Chunyu Hu
2026-03-17 18:37 ` [PATCH v3 0/5] selftests/mm: skip several tests when thp is " Andrew Morton
2026-03-18 9:22 ` Chunyu Hu
2026-03-18 11:32 ` Lorenzo Stoakes (Oracle)
2026-03-19 15:05 ` Chunyu Hu [this message]
2026-03-18 12:07 ` David Hildenbrand (Arm)
2026-03-19 15:08 ` Chunyu Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abwQx-P3pfyJ14ve@gmail.com \
--to=chuhu@redhat.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=npache@redhat.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.