From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Brian Geffon <bgeffon@google.com>,
Richard Chang <richardycc@google.com>,
linux-block@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] zram: do not slot_free() written-back slots
Date: Thu, 19 Mar 2026 12:43:16 -0700 [thread overview]
Message-ID: <abxR1Pm-JksGZYly@google.com> (raw)
In-Reply-To: <20260319034912.1894770-1-senozhatsky@chromium.org>
On Thu, Mar 19, 2026 at 12:44:56PM +0900, Sergey Senozhatsky wrote:
> slot_free() basically completely resets the slots by clearing
> all of its flags and attributes. While zram_writeback_complete()
> restores some of flags back (those that are necessary for async
> read decompression) we still lose a lot of slot's metadata. For
> example, slot's ac-time, or ZRAM_INCOMPRESSIBLE.
>
> Do not slot_free() on writeback, instead clear only those
> flags/attrs that we need to clear.
>
> Fixes: d38fab605c667 ("zram: introduce compressed data writeback")
> Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Acked-by: Minchan Kim <minchan@kernel.org>
With small nit about the description in previous comment,
prev parent reply other threads:[~2026-03-19 19:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 3:44 [PATCH] zram: do not slot_free() written-back slots Sergey Senozhatsky
2026-03-19 4:05 ` Sergey Senozhatsky
2026-03-19 6:47 ` Richard Chang
2026-03-19 7:21 ` Sergey Senozhatsky
2026-03-19 17:59 ` Minchan Kim
2026-03-19 19:43 ` Minchan Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abxR1Pm-JksGZYly@google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bgeffon@google.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richardycc@google.com \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.