From: Sabrina Dubroca <sd@queasysnail.net>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, Kuniyuki Iwashima <kuniyu@google.com>
Subject: Re: [PATCH net] rtnetlink: fix leak of SRCU struct in rtnl_link_register
Date: Fri, 20 Mar 2026 08:23:42 +0100 [thread overview]
Message-ID: <abz1_nbd2ep-RL6Q@krikkit> (raw)
In-Reply-To: <20260319170541.27c75eac@kernel.org>
2026-03-19, 17:05:41 -0700, Jakub Kicinski wrote:
> On Wed, 18 Mar 2026 17:15:15 +0100 Sabrina Dubroca wrote:
> > list_add_tail_rcu(&ops->list, &link_ops);
> > unlock:
> > + if (err)
> > + cleanup_srcu_struct(&ops->srcu);
> > +
> > mutex_unlock(&link_ops_mutex);
>
> Does the cleanup have to be under the lock?
Right. I'll send a v2.
(OTOH I don't think we'll ever have to worry about contention on this
lock, but we've probably said that about many locks in the past)
--
Sabrina
next prev parent reply other threads:[~2026-03-20 7:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 16:15 [PATCH net] rtnetlink: fix leak of SRCU struct in rtnl_link_register Sabrina Dubroca
2026-03-19 4:15 ` Kuniyuki Iwashima
2026-03-20 0:04 ` Jakub Kicinski
2026-03-20 0:05 ` Jakub Kicinski
2026-03-20 7:23 ` Sabrina Dubroca [this message]
2026-03-21 0:35 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abz1_nbd2ep-RL6Q@krikkit \
--to=sd@queasysnail.net \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.