From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Metcalf Subject: Re: [PATCH 5/5] tile: Define AT_VECTOR_SIZE_ARCH for ARCH_DLINFO Date: Mon, 25 Jul 2016 12:37:50 -0400 Message-ID: References: <1469462394-8970-1-git-send-email-james.hogan@imgtec.com> <1469462394-8970-6-git-send-email-james.hogan@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-db5eur01on0054.outbound.protection.outlook.com ([104.47.2.54]:27121 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753073AbcGYVJo (ORCPT ); Mon, 25 Jul 2016 17:09:44 -0400 In-Reply-To: <1469462394-8970-6-git-send-email-james.hogan@imgtec.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: James Hogan , linux-arch@vger.kernel.org Cc: linux-kernel@vger.kernel.org On 7/25/2016 11:59 AM, James Hogan wrote: > AT_VECTOR_SIZE_ARCH should be defined with the maximum number of > NEW_AUX_ENT entries that ARCH_DLINFO can contain, but it wasn't defined > for tile at all even though ARCH_DLINFO will contain one NEW_AUX_ENT for > the VDSO address. > > This shouldn't be a problem as AT_VECTOR_SIZE_BASE includes space for > AT_BASE_PLATFORM which tile doesn't use, but lets define it now and add > the comment above ARCH_DLINFO as found in several other architectures to > remind future modifiers of ARCH_DLINFO to keep AT_VECTOR_SIZE_ARCH up to > date. > > Fixes: 4a556f4f56da ("tile: implement gettimeofday() via vDSO") > Signed-off-by: James Hogan > Cc: Chris Metcalf > --- > arch/tile/include/asm/elf.h | 1 + > arch/tile/include/uapi/asm/auxvec.h | 2 ++ > 2 files changed, 3 insertions(+) Thanks, taken into the tile tree. I'm a little dubious that AT_VECTOR_SIZE_ARCH should be being defined in the uapi version of auxvec.h, since I don't see why userspace should be interested in it, but that does seem to be the current convention. Ugh, there are even CONFIG_xxx ifdefs in the x86 and sh uapi/asm/auxvec.h ... Maybe the define could be moved to arch/*/include/asm/elf.h? -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753816AbcGYVLL (ORCPT ); Mon, 25 Jul 2016 17:11:11 -0400 Received: from mail-db5eur01on0054.outbound.protection.outlook.com ([104.47.2.54]:27121 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753073AbcGYVJo (ORCPT ); Mon, 25 Jul 2016 17:09:44 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=cmetcalf@mellanox.com; Subject: Re: [PATCH 5/5] tile: Define AT_VECTOR_SIZE_ARCH for ARCH_DLINFO To: James Hogan , References: <1469462394-8970-1-git-send-email-james.hogan@imgtec.com> <1469462394-8970-6-git-send-email-james.hogan@imgtec.com> CC: From: Chris Metcalf Message-ID: Date: Mon, 25 Jul 2016 12:37:50 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1469462394-8970-6-git-send-email-james.hogan@imgtec.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [12.216.194.146] X-ClientProxiedBy: BN3PR15CA0028.namprd15.prod.outlook.com (10.165.72.38) To AM4PR05MB1681.eurprd05.prod.outlook.com (10.165.245.152) X-MS-Office365-Filtering-Correlation-Id: 5119617d-e647-49ae-9862-08d3b4aa09d8 X-Microsoft-Exchange-Diagnostics: 1;AM4PR05MB1681;2:Rg/6zbnIET+nNbh/TG3u1tldLuDRKRIFdlYRCCp1ZZWXgpKIei6NE2rcuGx50qEFU/kaTBjJ9ILr8T3NbXe1U5ALMUzCTJRrJw+oOjCfYWJ2c/v9LwdZb0/ljMi5+nDXBIs4sOZt6VVnKqwjtjgkd3KhkkrlzfexUb6z2lPHm8z/3Kd/tb8+4eImMYS3kbrm;3:WM6uGcrFVLV4siJB5A1NdRF0FS1BoBgK7/CSPvMRV4OKseRvOcc8yvFMJUEsGFzg4w8hl7gX5IO1ZyYdMNbEUQlipO2egyGBAzKSj9HqRowPB35f+Tf9Vzb+7pE+2yLa;25:Ne4qwoQGgOlY/eGSBDdkNilApxIoHiki9h2HoMUv2VHiHzzE3ubWswPocBAk2tX/hPibLBPHaM65svZLddPVRDOlz8biagma0+cThIjXvQWf+mnnLHLCTQylZh6ddT/UeFwJuOa4AMPlUMEnhIW2URtoc5FiAQlEMcHGsUaSmdvBwOtovLYlxorQkrEbZTOANafr2YHUyam+sIRK8uFOlAt5NSvlft8YaL0NjdBx2htkWG1wJLJQVbTDn+E/P2qApU/Fk3ILYJ7iMLBPIGtavoXR1YCbsLEXxkcpTHT9FKim16pFz6VhIfvxPNOyFIq4+q8OLUkzaf9rzxb8l4pJLc6yVorqI8ZfGgVpTELR5Sgd7Lzsj3pPWB1cwQfeGjCiSne33KVwKFZP7M33KvaEN2JT/6uw3Vt5FzmjjcP3AJc=;31:UsZ0xgdKDbZH/Lh+FuuMD74YuQ9dg+1ebyI52IBpMvmV7gM7WQfVtZpWnjhOqn8SpYMIxlZHtnlUqkaP7KruAgyc+u9kC4o9UqGwuD+mdNNC1PWFpzlQiWAOsiVDvXnd3vwOzt27ScqA/ANjnCKY8R0vAwCOJF5HjIC7huVXQJlfpxhxHMKNQ1Dxf7OLOx3C/E8VOsRFekMKIZ8kZnLzUQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM4PR05MB1681; X-Microsoft-Exchange-Diagnostics: 1;AM4PR05MB1681;20:KRXIokmviaFieH0zS//3YsMHw/4RLtxmGXAXd3AfayQcungH4AyFAqriYkF6zTCMaKyiCHs+bUvGOPMAeLbaO+Yu/lnBUvNML/BbR+OAeEHgt+vQS9r7QjKX08wgnFk6U/ZspONYPpTKYT+hr+4DU2c/Auzte2GR1UdhNsLkUvBfc2e1FIbYO9MNbvDL/KShQvl93X6675s34nw75WOwe37g1cfhIsn4VDiTZRMEeEZA0kAAuvbFmPW64jwlchdnk0Vqrr8aaHOEsIDdRh83aD75WFFcAYp1mUJb8FVM9tNfxqIfi1ayc8IjYitoqQAibv+szw7yrn8IsWgxMk458FB9uOHyxcuhV1wsENn2of1hQJDdFVAF9zbfzPoEO2T084Vf0leT3MW3qCaALJZLilgVLm1SdYj5yu2H3rV4yMAkworrg+OGi0KbOmqDfHktsQtNIDwYgWDY8XEHCc5xTqEY//BWj5WVtcwos02cLLRbUpst/1yutx92xbMBXVnA;4:R/UrmHD28+YAElYYt6TCWqCdJMJ5RaMvsrK9/J8QRl9Ox7G0I6GvnlEqtUlIuY2MtxTXOPVlGL2tKXaFeX/LLgtrFOKP/7ksGCAlyF45uzh/Kh/JuKKt/r6htPkfTfFbIq3JOASq0YYn6tWBZl1dhjq/XcYkIXuXKyUj3bWl/ahsM8ZFDtee2uDNpAwOhzwP3ZNSeSgMDgJtm8eIAfCE/s0Q+Dd2ITAD/Yl6eegiq0gD4J3rzKvKke7m144qUTXPqZRHMHC5F9dbcpUJcX+My5/E8iUyZnZNBMxAoX/zMMtdZgtt+dmHiw+Y3cYKd2nyOkj/O4xvLF5j2s0fIxEPVKtgjyrBDQgc0AbdugMCETcYUxJmza/1Tmy4Lj59Ins28Z3PydzAOSsc0CShuip2NEXVF3BVDIPLjL0wgEGMIU48hH1L019o4VhTv+fxt9Zo X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(171992500451332); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:AM4PR05MB1681;BCL:0;PCL:0;RULEID:;SRVR:AM4PR05MB1681; X-Forefront-PRVS: 0014E2CF50 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(7916002)(199003)(189002)(377454003)(24454002)(42186005)(586003)(4001350100001)(23746002)(3846002)(31686004)(6116002)(47776003)(86362001)(4326007)(81166006)(81156014)(65806001)(97736004)(305945005)(76176999)(54356999)(50986999)(19580405001)(7736002)(106356001)(15975445007)(5001770100001)(19580395003)(101416001)(77096005)(66066001)(83506001)(105586002)(65956001)(189998001)(8676002)(31696002)(2950100001)(64126003)(2906002)(33646002)(68736007)(92566002)(7846002)(230700001)(50466002)(36756003)(65826006)(21314002)(18886065003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM4PR05MB1681;H:[10.15.6.55];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AM4PR05MB1681;23:SEutfkVEv1SPmPUZvhBMCzQH55TPjykZ+kVri?= =?Windows-1252?Q?BFl/ZhsxLmvZp+Lw20RYVxomDBgB/REeyYr+ZugYPUk+V3yCbuuOnGae?= =?Windows-1252?Q?Ga6A4Idyu1Bup9cUuAyirfUbJIZDpq3uukDp90UDmTXFa5bNkFSx/H0Y?= =?Windows-1252?Q?1zJEHRbTDYY8a0DjAtj/kjnELPwPqpBEoV3mUnVtQMZd5QD2SM8CtnpR?= =?Windows-1252?Q?29XDm0NB4roR4VRSZqGnu13WCdE4U4E9bBn0rjIcdzsXO4W0jN4ZH9PF?= =?Windows-1252?Q?x3Hp23DM9DdmicWszAhQcgYJOOeCLJc1kC2wNF60MwtOiQ/km66uTJF8?= =?Windows-1252?Q?5s+IWjLpYzLK5Jkk2iQyc+UNkzH4uuBzxMWWh6bguEatCW+Gormvuxrh?= =?Windows-1252?Q?iJA8bo6q1uyxVUv1eLDoQ67pe3dNMmTadTHdNhrSe3DzCMI+6sBriSoV?= =?Windows-1252?Q?/xhAFb3SlFg6Chwo5B2D3Q2d6wQW3TsyQ6e9CcEv+UT386uKzqpPfe9s?= =?Windows-1252?Q?O2RPPv0ZpZAf2CmUSS9Hb1p2IJU6JTnh5qLYJZTjieFGDaTUk4KpUmzD?= =?Windows-1252?Q?QUjqAyCDDEGCodVWADGB4Aw3cKHNWR0dl/YAq8TrUfKGDrg25UYFihQZ?= =?Windows-1252?Q?ie2XGC7u7yWisrJo/iX/h2xwUR/a+dyNn+X7rUP44mhMmzNk92+uNdpj?= =?Windows-1252?Q?xSAZd7cMSC96+JDaPkC5sSawEVD044YfLaYo0BUhCVPNmbFdIn7ux5If?= =?Windows-1252?Q?kkLOf5Cu/Z45P0kW5jdysSqw3gldioHZ2SsTz+1/H8KzPmM3Lq8Tegx8?= =?Windows-1252?Q?mnBAycUEFzgvsdHtrIUMkRPQFT6eYqwXX4S57SlbJbzdwmlU9MHs23ug?= =?Windows-1252?Q?0ONtNQKYLKfKz8vuSpsiAb+dbbfp3K9BOMNzR46+jAJ1PSwk1Si4PXd7?= =?Windows-1252?Q?fN/6ebwrXupAW7p8ckavCYEPTakg33jFzxI1O9Q5aGeHIBbjg60/5C3o?= =?Windows-1252?Q?BBw7ibY/AkL1AtkuW+vqtDbMHd7Ih+7cxyxMJicGZsYLe97y8q8xBCXh?= =?Windows-1252?Q?KkTIHZUDYaAWDbjLugTBjb6Aed7m6uE4sRMRoxxDWTuQsmUUJ5ZYnAF+?= =?Windows-1252?Q?ewp5DDBE5W+gFRSbszFhkNn6JBcBi9guknB3KDeSb70BBa8SmSXoqrgE?= =?Windows-1252?Q?ujMthEKG1P6MkVsC+UHdnKR291Vwq49gzgqCQprJuxvCGGLyu4Qu/hfl?= =?Windows-1252?Q?sh8IEMAkP4u0iw0T3vGDNPImxxLdNzvPDAGQgus7oRbtHI6bKTOhHGGS?= =?Windows-1252?Q?N92v3Ot/BcbZKfk/TRZStS2EyqjFRzuunAT5BKsnGo76n6Z9Wwj4kTkF?= =?Windows-1252?Q?x0FgdBCtFRhJOwk4yRQ6fPli70ufkbghEsrAd8hNmd331rabHz7bRilB?= =?Windows-1252?Q?oMOl0CCfXO1Ppoc6wZGm/wnN13bBLGJ0qilF55/Jg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM4PR05MB1681;6:W29tDcMsQIdxr7uuriCVifyir5f91UEVRqs4huhCVzPHvjQhqMoGX7/F3XXcd2vMltH/T9ajYOphH+zjWier4Pap3dZXMp11EYuwoCU0ZGP3kMHGoNY/NlDVeEy1z5zQlvoV7YZzcdQwd0fBr/MCTv6Cjjj/VbJuoCYV86NA0pvmkTB9ZuQ7tpwHu4ThZ4V1G+jWsy+rMc4AhrufH62R5p8qIvou7uRXXc8gjkIB2U9byz+sVkgBRvEZxumh/yb6WGW0o1SVXeyfyN815r/US4akMVDPztfzm3UZgR/dyvRNwHf6mI0Ys/6N3Xk+Ja5SyvaODeAIFifXY9ANVphuKQ==;5:undBZv6ALP5mfNDIXwFRhEq5OAl2mhYEXLjhH/LRuKwp9QUxm2646eVqhlA3AKl1T1jzDfCXT/SI/BEezO9IHtlzUFim6gXEZAOf3jIPCaHLUJbfSsjxv3IJlwaGmJjRRKvrnREi20rvpBut85CjPQ==;24:jRgRVBAorjsdZl/IThpsvvL7Pk5GVF0gNQIq7evlkNnhrf5Fr/ZJa12t/noaKkSLsWya1sr5zM08m1DjIs0FMQ/G65lyLpJ0APeBhTGE284=;7:75YunpYc32AAffUvLVJaMBG398+U7LbYU9z6u85j29psdBgD+gGMslOI/uCur+g2YU6bwFtC9QoB6KMhHSZIrXhylKjKE9Jf02LmLOB4CIXdyHOFInv+sI3GHGzfE7grkz2l6F62y8Hl2PfC/cIH5MWKL400zUA5c6Rd1zGUIDIA6zgA9cij42+lnIMsgfVGlAMLGHnhAPJJdOSFqL3yxWlFhdAggcUPJzBXw2xRd9rdrL0i1yl8mrXIbGLcBBAb SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2016 16:37:58.6557 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB1681 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/25/2016 11:59 AM, James Hogan wrote: > AT_VECTOR_SIZE_ARCH should be defined with the maximum number of > NEW_AUX_ENT entries that ARCH_DLINFO can contain, but it wasn't defined > for tile at all even though ARCH_DLINFO will contain one NEW_AUX_ENT for > the VDSO address. > > This shouldn't be a problem as AT_VECTOR_SIZE_BASE includes space for > AT_BASE_PLATFORM which tile doesn't use, but lets define it now and add > the comment above ARCH_DLINFO as found in several other architectures to > remind future modifiers of ARCH_DLINFO to keep AT_VECTOR_SIZE_ARCH up to > date. > > Fixes: 4a556f4f56da ("tile: implement gettimeofday() via vDSO") > Signed-off-by: James Hogan > Cc: Chris Metcalf > --- > arch/tile/include/asm/elf.h | 1 + > arch/tile/include/uapi/asm/auxvec.h | 2 ++ > 2 files changed, 3 insertions(+) Thanks, taken into the tile tree. I'm a little dubious that AT_VECTOR_SIZE_ARCH should be being defined in the uapi version of auxvec.h, since I don't see why userspace should be interested in it, but that does seem to be the current convention. Ugh, there are even CONFIG_xxx ifdefs in the x86 and sh uapi/asm/auxvec.h ... Maybe the define could be moved to arch/*/include/asm/elf.h? -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com