From: Randy Dunlap <rdunlap@infradead.org>
To: Ivan Vecera <ivecera@redhat.com>, netdev@vger.kernel.org
Cc: Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
Prathosh Satish <Prathosh.Satish@microchip.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Michal Schmidt <mschmidt@redhat.com>,
Petr Oros <poros@redhat.com>
Subject: Re: [PATCH net-next v2 5/5] dpll: zl3073x: Implement devlink flash callback
Date: Mon, 11 Aug 2025 14:16:38 -0700 [thread overview]
Message-ID: <ac154cf5-4631-4506-bfe2-9442ef3701db@infradead.org> (raw)
In-Reply-To: <20250811144009.2408337-6-ivecera@redhat.com>
Hi--
On 8/11/25 7:40 AM, Ivan Vecera wrote:
> +/**
> + * zl3073x_flash_update - Devlink flash update callback
> + * @devlink: devlink structure pointer
> + * @params: flashing parameters pointer
> + * @extack: netlink extack pointer to report errors
> + *
> + * Returns 0 in case of success or negative value otherwise
Preferably with a colon:
* Returns: 0 in case of success or negative value otherwise
> + */
> +static int
> +zl3073x_devlink_flash_update(struct devlink *devlink,
> + struct devlink_flash_update_params *params,
> + struct netlink_ext_ack *extack)
> +{
Thanks.
--
~Randy
prev parent reply other threads:[~2025-08-11 21:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 14:40 [PATCH net-next v2 0/5] dpll: zl3073x: Add support for devlink flash Ivan Vecera
2025-08-11 14:40 ` [PATCH net-next v2 1/5] dpll: zl3073x: Add functions to access hardware registers Ivan Vecera
2025-08-11 14:40 ` [PATCH net-next v2 2/5] dpll: zl3073x: Add low-level flash functions Ivan Vecera
2025-08-11 22:29 ` Przemek Kitszel
2025-08-13 12:17 ` Ivan Vecera
2025-08-11 14:40 ` [PATCH net-next v2 3/5] dpll: zl3073x: Add firmware loading functionality Ivan Vecera
2025-08-11 23:11 ` Przemek Kitszel
2025-08-13 12:43 ` Ivan Vecera
2025-08-11 14:40 ` [PATCH net-next v2 4/5] dpll: zl3073x: Refactor DPLL initialization Ivan Vecera
2025-08-11 14:40 ` [PATCH net-next v2 5/5] dpll: zl3073x: Implement devlink flash callback Ivan Vecera
2025-08-11 21:16 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac154cf5-4631-4506-bfe2-9442ef3701db@infradead.org \
--to=rdunlap@infradead.org \
--cc=Prathosh.Satish@microchip.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=poros@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.