From: Leon Hwang <leon.hwang@linux.dev>
To: Tiezhu Yang <yangtiezhu@loongson.cn>,
Xu Kuohai <xukuohai@huaweicloud.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>
Cc: Puranjay Mohan <puranjay@kernel.org>,
loongarch@lists.linux.dev, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next v2] bpf: Fix unaligned interpreter panic on JIT fallback path
Date: Mon, 15 Jun 2026 10:15:45 +0800 [thread overview]
Message-ID: <ac19b45f-9272-46f3-bd87-7249e22be338@linux.dev> (raw)
In-Reply-To: <ad046aad-c258-d121-41a2-7fa823b3cb02@loongson.cn>
On 15/6/26 10:05, Tiezhu Yang wrote:
> On 2026/6/15 上午9:49, Leon Hwang wrote:
>> On 15/6/26 09:23, Tiezhu Yang wrote:
[...]
>>
>> I think bpf_fixup_inline_helpers() is not accurate, since it is to fix
>> those non-inline helpers here. bpf_fixup_non_inline_helpers() is a
>> candidate. However, a shorter name is preferred.
>
> I see your point. Indeed, we are fixing up the helpers that ultimately
> failed to be inlined on the fallback path.
>
> How about shortening it to fixup_fallback_helpers()? Since it is a
> static function, we can safely drop the bpf_ prefix to keep it concise,
> clean, and accurate.If that looks good to you, I will use this name and
> remove the redundant check in the next version.
>
bpf_fixup_fallback_helpers() or fixup_fallback_helpers() works for me.
Thanks,
Leon
prev parent reply other threads:[~2026-06-15 2:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 10:12 [PATCH bpf-next v2] bpf: Fix unaligned interpreter panic on JIT fallback path Tiezhu Yang
2026-06-11 10:23 ` Leon Hwang
2026-06-11 10:54 ` bot+bpf-ci
2026-06-11 11:28 ` Tiezhu Yang
2026-06-12 12:37 ` Xu Kuohai
2026-06-15 1:23 ` Tiezhu Yang
2026-06-15 1:49 ` Leon Hwang
2026-06-15 2:05 ` Tiezhu Yang
2026-06-15 2:15 ` Leon Hwang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac19b45f-9272-46f3-bd87-7249e22be338@linux.dev \
--to=leon.hwang@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=puranjay@kernel.org \
--cc=xukuohai@huaweicloud.com \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.