From: Trond Myklebust <trondmy@hammerspace.com>
To: "anna.schumaker@netapp.com" <anna.schumaker@netapp.com>,
"neilb@suse.com" <neilb@suse.com>
Cc: "dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] SUNRPC: remove pointless test in unx_match()
Date: Thu, 21 Feb 2019 22:39:15 +0000 [thread overview]
Message-ID: <ac353cb75792fbeea79fd53c4e477bee455a6ae5.camel@hammerspace.com> (raw)
In-Reply-To: <87d0p9j6v3.fsf@notabene.neil.brown.name>
On Mon, 2019-01-07 at 17:53 +1100, NeilBrown wrote:
> As reported by Dan Carpenter, this test for acred->cred being set is
> inconsistent with the dereference of the pointer a few lines earlier.
>
> An 'auth_cred' *always* has ->cred set - every place that creates one
> initializes this field, often as the first thing done.
>
> So remove this test.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: NeilBrown <neilb@suse.com>
>
Thanks Neil! Applied to the linux-next branch for inclusion in the 5.1
merge window.
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com
prev parent reply other threads:[~2019-02-21 22:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 9:10 [bug report] SUNRPC: simplify auth_unix Dan Carpenter
2019-01-07 6:53 ` [PATCH] SUNRPC: remove pointless test in unx_match() NeilBrown
2019-02-21 22:39 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac353cb75792fbeea79fd53c4e477bee455a6ae5.camel@hammerspace.com \
--to=trondmy@hammerspace.com \
--cc=anna.schumaker@netapp.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.