All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: phucduc.bui@gmail.com
Cc: Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	 Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Jeff LaBundy <jeff@labundy.com>,
	 Bastian Hecht <hechtb@gmail.com>,
	Javier Carrasco <javier.carrasco@wolfvision.net>,
	 linux-input@vger.kernel.org, devicetree@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] input: touchscreen: st1232: add system wakeup support
Date: Wed, 1 Apr 2026 22:17:31 -0700	[thread overview]
Message-ID: <ac37o-N5lqFMwDCC@google.com> (raw)
In-Reply-To: <20260306111912.58388-4-phucduc.bui@gmail.com>

On Fri, Mar 06, 2026 at 06:19:12PM +0700, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
> 
> The ST1232 touchscreen controller can generate an interrupt when the
> panel is touched, which may be used as a wakeup source for the system.
> 
> Add support for system wakeup by initializing the device wakeup
> capability in probe() based on the "wakeup-source" device property.
> When wakeup is enabled, the driver enables IRQ wake during suspend
> so that touch events can wake the system.
> 
> If wakeup is not enabled, the driver retains the existing behavior of
> disabling the IRQ and powering down the controller during suspend.

I do not believe this patch is needed: i2c core already handles
"wakeup-source" property and manages wakeup IRQ.

Thanks.

-- 
Dmitry

  reply	other threads:[~2026-04-02  5:17 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-05 11:35 [PATCH 0/2] st1232: Add wakeup-source support phucduc.bui
2026-03-05 11:35 ` [PATCH 1/2] dt-bindings: input: touchscreen: sitronix,st1232: Add wakeup-source phucduc.bui
2026-03-06  8:18   ` Krzysztof Kozlowski
2026-03-06 10:24     ` phucduc.bui
2026-03-05 11:35 ` [PATCH 2/2] arm: dts: renesas: r8a7740-armadillo800eva: Add wakeup-source to st1232 phucduc.bui
2026-03-06 10:40 ` [PATCH v2 0/3] Input: st1232 - add system wakeup support phucduc.bui
2026-03-06 10:40   ` [PATCH v2 1/3] dt-bindings: input: touchscreen: sitronix,st1232: Add wakeup-source phucduc.bui
2026-03-06 10:42     ` Krzysztof Kozlowski
2026-03-07  2:46       ` phucduc.bui
2026-03-06 10:40   ` [PATCH v2 2/3] arm: dts: renesas: r8a7740-armadillo800eva: Add wakeup-source to st1232 phucduc.bui
2026-03-06 10:40   ` [PATCH v2 3/3] input: touchscreen: st1232: add system wakeup support phucduc.bui
2026-03-06 10:44     ` Krzysztof Kozlowski
2026-03-07  2:50       ` phucduc.bui
2026-03-06 11:19   ` [PATCH v3 0/3] Input: st1232 - " phucduc.bui
2026-03-06 11:19     ` [PATCH v3 1/3] dt-bindings: input: touchscreen: sitronix,st1232: Add wakeup-source phucduc.bui
2026-03-06 11:19     ` [PATCH v3 2/3] arm: dts: renesas: r8a7740-armadillo800eva: Add wakeup-source to st1232 phucduc.bui
2026-03-06 11:19     ` [PATCH v3 3/3] input: touchscreen: st1232: add system wakeup support phucduc.bui
2026-04-02  5:17       ` Dmitry Torokhov [this message]
2026-04-02  6:56         ` Geert Uytterhoeven
2026-04-03 11:39           ` Bui Duc Phuc
2026-03-06 11:49     ` [PATCH v3 0/3] Input: st1232 - " Wolfram Sang
2026-03-07  2:53       ` phucduc.bui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac37o-N5lqFMwDCC@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=hechtb@gmail.com \
    --cc=javier.carrasco@wolfvision.net \
    --cc=jeff@labundy.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=phucduc.bui@gmail.com \
    --cc=robh@kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.