From: Gregor Herburger <gregor.herburger@linutronix.de>
To: Simon Glass <sjg@chromium.org>
Cc: u-boot@lists.denx.de, Quentin Schulz <quentin.schulz@cherry.de>,
Andrew Goodbody <andrew.goodbody@linaro.org>,
Heiko Schocher <hs@nabladev.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Jerome Forissier <jerome.forissier@arm.com>,
"Kory Maincent (TI.com)" <kory.maincent@bootlin.com>,
Mattijs Korpershoek <mkorpershoek@kernel.org>,
Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>,
Tom Rini <trini@konsulko.com>
Subject: Re: [v2,2/2] cli: flush stdin before enabling cli
Date: Thu, 2 Apr 2026 10:06:09 +0200 [thread overview]
Message-ID: <ac4jcb5rmFG3qDz-@gregor-framework> (raw)
In-Reply-To: <CAFLszTg_LiyHPYhQh+MTV5skuY0ORrPotOFQWkQSQvsBzjHTYw@mail.gmail.com>
Hi Simon,
> Just to check, does this option also need 'depends on !SANDBOX' like
> AUTOBOOT_FLUSH_STDIN does? That option notes that flushing stdin
> breaks autoboot unit tests. I suspect the CLI entry path might not be
> exercised by those tests, but it would be good to confirm.
I now tested a bit with the sandbox and I couldn't find any issues. I
ran some unit tests with/without this patch series and with
CMDLINE_FLUSH_STDIN enabled/disabled and couldn't find any issues. I
also ran `u-boot -c bdinfo` which seems to be executed after the
cli_init and therefore after the flush but I could't see any issues
here.
But this is the first time for me using the sandbox so I don't know what
I could test further. If anybody has an idea what tests could be run let
me know. Otherwise I will send a v3 with an updated help text.
Best regards
Gregor
next prev parent reply other threads:[~2026-04-02 8:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-01 12:40 [PATCH v2 1/2] console: add console_flush_stdin() Gregor Herburger
2026-04-01 12:40 ` [PATCH v2 2/2] cli: flush stdin before enabling cli Gregor Herburger
2026-04-02 0:15 ` [v2,2/2] " Simon Glass
2026-04-02 8:06 ` Gregor Herburger [this message]
2026-04-03 13:22 ` Simon Glass
2026-04-01 13:23 ` [PATCH v2 1/2] console: add console_flush_stdin() Sverdlin, Alexander
2026-04-01 13:45 ` Quentin Schulz
2026-04-02 0:14 ` [v2,1/2] " Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac4jcb5rmFG3qDz-@gregor-framework \
--to=gregor.herburger@linutronix.de \
--cc=andrew.goodbody@linaro.org \
--cc=hs@nabladev.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jerome.forissier@arm.com \
--cc=kory.maincent@bootlin.com \
--cc=mikhail.kshevetskiy@iopsys.eu \
--cc=mkorpershoek@kernel.org \
--cc=quentin.schulz@cherry.de \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.