From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Janusz Krzysztofik <jmkrzyszt@gmail.com>,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@armlinux.org.uk>,
Kevin Hilman <khilman@baylibre.com>,
Arnd Bergmann <arnd@arndb.de>,
brgl@kernel.org, driver-core@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v5 4/4] ARM: omap1: enable real software node lookup of GPIOs on Nokia 770
Date: Thu, 2 Apr 2026 10:32:18 -0700 [thread overview]
Message-ID: <ac6n1p3eLVFzumbt@google.com> (raw)
In-Reply-To: <20260402-nokia770-gpio-swnodes-v5-4-d730db3dd299@oss.qualcomm.com>
On Thu, Apr 02, 2026 at 04:15:05PM +0200, Bartosz Golaszewski wrote:
> @@ -244,6 +263,13 @@ static int __init omap16xx_gpio_init(void)
> iounmap(base);
>
> platform_device_register(omap16xx_gpio_dev[i]);
> +
> + ret = device_add_software_node(&omap16xx_gpio_dev[i]->dev,
> + omap16xx_gpio_swnodes[i]);
> + if (ret) {
> + dev_err(&pdev->dev, "Failed to add software node.\n");
> + return ret;
> + }
I think the best and safest way is to convert to using
platform_driver_register_full() and set swnode in the relevant "info"
instance.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2026-04-02 17:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 14:15 [PATCH v5 0/4] ARM: omap1: use real firmware node lookup for GPIOs on Nokia 770 Bartosz Golaszewski
2026-04-02 14:15 ` [PATCH v5 1/4] kernel: ksysfs: initialize kernel_kobj earlier Bartosz Golaszewski
2026-04-02 16:39 ` Danilo Krummrich
2026-04-02 16:40 ` Bartosz Golaszewski
2026-04-02 14:15 ` [PATCH v5 2/4] software node: remove software_node_exit() Bartosz Golaszewski
2026-04-02 16:19 ` Andy Shevchenko
2026-04-02 19:46 ` Dmitry Torokhov
2026-04-02 14:15 ` [PATCH v5 3/4] driver core: make software nodes available earlier Bartosz Golaszewski
2026-04-02 16:20 ` Andy Shevchenko
2026-04-02 14:15 ` [PATCH v5 4/4] ARM: omap1: enable real software node lookup of GPIOs on Nokia 770 Bartosz Golaszewski
2026-04-02 16:23 ` Andy Shevchenko
2026-04-02 17:32 ` Dmitry Torokhov [this message]
2026-04-03 7:23 ` Bartosz Golaszewski
2026-04-02 16:29 ` [PATCH v5 0/4] ARM: omap1: use real firmware node lookup for " Danilo Krummrich
2026-04-04 13:47 ` (subset) " Danilo Krummrich
2026-04-07 14:16 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac6n1p3eLVFzumbt@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=dakr@kernel.org \
--cc=djrscally@gmail.com \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jmkrzyszt@gmail.com \
--cc=khilman@baylibre.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.