Re: [PATCH] serial: 8250_core: fix coding style issues

[Jiri Slaby <jirislaby@kernel.org>]

On 21. 08. 25, 19:58, Osama Abdelkader wrote:
> Fix a few coding style issues in 8250_core.c:
> 
> - Remove redundant NULL initialization of a global pointer
> - Add missing blank line after a variable declaration
> 
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
> ---
>   drivers/tty/serial/8250/8250_core.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> index feb920c5b2e8..0d1d2eed2a5c 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -307,7 +307,7 @@ static void univ8250_release_irq(struct uart_8250_port *up)
>   		serial_unlink_irq_chain(up);
>   }
>   
> -const struct uart_ops *univ8250_port_base_ops = NULL;
> +const struct uart_ops *univ8250_port_base_ops;
>   struct uart_ops univ8250_port_ops;
>   
>   static const struct uart_8250_ops univ8250_driver_ops = {
> @@ -773,6 +773,7 @@ int serial8250_register_8250_port(const struct uart_8250_port *up)
>   	 */
>   	if (!has_acpi_companion(uart->port.dev)) {
>   		struct mctrl_gpios *gpios = mctrl_gpio_init(&uart->port, 0);
> +
>   		if (IS_ERR(gpios)) {

NACK to this one. It's a declaration with an initializer and the 'if' 
checks its value.

>   			ret = PTR_ERR(gpios);
>   			goto err;


-- 
js
suse labs