From: Segher Boessenkool <segher@kernel.crashing.org>
To: "Li Yang-r58472" <LeoLi@freescale.com>
Cc: linuxppc-dev@ozlabs.org, Tabi Timur-B04825 <timur@freescale.com>
Subject: Re: [PATCH v7 3/3] [POWERPC] MPC832x_RDB: update dts to use SPI1in QE, register mmc_spi stub
Date: Sun, 2 Sep 2007 01:59:45 +0200 [thread overview]
Message-ID: <ac803797588b40e3d33bbd6f758a5663@kernel.crashing.org> (raw)
In-Reply-To: <989B956029373F45A0B8AF02970818900147BD4D@zch01exm26.fsl.freescale.net>
>>> + par_io_config_pin(3, 13, 1, 0, 0, 0); /* !SD_CS, O */
>>> + par_io_config_pin(3, 14, 2, 0, 0, 0); /* SD_INSERT, I */
>>> + par_io_config_pin(3, 15, 2, 0, 0, 0); /* SD_PROTECT,I */
>>
>> Why are you doing this here, and not in the device tree?
>
> I saw you used pio node, but later changed to make it hardcoded.
> What's
> the reason? IMO, device tree is used to describe the hardware
> settings,
> pio node is a perfect match.
Not at all. The device tree describe how the hardware _is_
set up (after firmware, bootloader etc.); now how it _should
be_ set up by the kernel.
It would make a lot of sense to do this work in the firmware
instead, but it doesn't make sense at all to put this stuff
into the device tree.
> Moreover, changing the device tree is much
> easier than changing the code.
How so? You don't like C code? :-)
Segher
next prev parent reply other threads:[~2007-09-02 0:00 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-21 13:45 [PATCH v4 0/2] SPI support for fsl_soc and mpc832x_rdb Anton Vorontsov
2007-08-21 13:47 ` [PATCH v4 1/2] [POWERPC] fsl_soc: add support for fsl_spi Anton Vorontsov
2007-08-21 13:47 ` [PATCH v4 2/2] [POWERPC] MPC832x_RDB: update dts to use SPI1 in QE, register mmc_spi stub Anton Vorontsov
2007-08-21 15:27 ` [PATCH v5 0/2] SPI support for fsl_soc and mpc832x_rdb Anton Vorontsov
2007-08-21 15:29 ` [PATCH v5 1/2] [POWERPC] fsl_soc: add support for fsl_spi Anton Vorontsov
2007-08-22 14:24 ` Kumar Gala
2007-08-21 15:29 ` [PATCH v5 2/2] [POWERPC] MPC832x_RDB: update dts to use SPI1 in QE, register mmc_spi stub Anton Vorontsov
2007-08-22 14:25 ` Kumar Gala
2007-08-22 14:22 ` [PATCH v5 0/2] SPI support for fsl_soc and mpc832x_rdb Kumar Gala
2007-08-22 14:54 ` [PATCH v6 " Anton Vorontsov
2007-08-22 14:57 ` [PATCH v6 1/2] [POWERPC] fsl_soc: add support for fsl_spi Anton Vorontsov
2007-08-23 3:24 ` Stephen Rothwell
2007-08-23 11:33 ` [PATCH v7 0/3] " Anton Vorontsov
2007-08-23 11:35 ` [PATCH v7 1/3] [POWERPC] QE lib: extern par_io_config_pin and par_io_data_set funcs Anton Vorontsov
2007-08-23 11:35 ` [PATCH v7 2/3] [POWERPC] fsl_soc: add support for fsl_spi Anton Vorontsov
2007-08-23 11:36 ` [PATCH v7 3/3] [POWERPC] MPC832x_RDB: update dts to use SPI1 in QE, register mmc_spi stub Anton Vorontsov
2007-08-30 21:06 ` Timur Tabi
2007-08-31 13:50 ` [PATCH v7 3/3] [POWERPC] MPC832x_RDB: update dts to use SPI1in " Li Yang-r58472
2007-09-01 23:59 ` Segher Boessenkool [this message]
2007-09-03 13:55 ` Timur Tabi
2007-09-03 15:13 ` Anton Vorontsov
2007-09-03 23:17 ` Segher Boessenkool
2007-09-04 10:47 ` Anton Vorontsov
2007-09-04 18:20 ` Scott Wood
2007-09-04 20:15 ` Vitaly Bordug
2007-09-05 11:40 ` Anton Vorontsov
2007-09-05 13:21 ` Scott Wood
2007-09-07 1:15 ` David Gibson
2007-09-07 1:28 ` Timur Tabi
2007-09-06 14:25 ` Segher Boessenkool
2007-09-06 14:19 ` Segher Boessenkool
2007-09-06 14:35 ` Timur Tabi
2007-09-03 23:12 ` Segher Boessenkool
2007-09-04 3:16 ` Timur Tabi
2007-09-06 14:13 ` Segher Boessenkool
2007-09-06 14:19 ` Scott Wood
2007-09-06 14:29 ` Segher Boessenkool
2007-09-07 3:37 ` David Gibson
2007-08-22 14:57 ` [PATCH v6 2/2] [POWERPC] MPC832x_RDB: update dts to use SPI1 in " Anton Vorontsov
2007-08-22 15:01 ` [PATCH v6 0/2] SPI support for fsl_soc and mpc832x_rdb Kumar Gala
2007-08-22 15:13 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac803797588b40e3d33bbd6f758a5663@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=LeoLi@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.