From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 689D323183B; Mon, 30 Mar 2026 07:50:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774857037; cv=none; b=B6wl4mkLKjUvK0SRm6CATZNIy2QGxyDXWwnsnbjIiYkU2EnZj8jk4a/PmdWaIWgKufuj0Pi58oXzsKMR4Y0dWLw6Vmx2RNrLxstoKS3soergsBHlQT5O0Qqz7Fpu4ISrsXpQaFPzrQDLbdQ9yocCw48BOo3XX2qabPRYzFOEJHo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774857037; c=relaxed/simple; bh=r6tj4wjTcXuf34OsWonOEaYIh+C+DzYKxkZwDt53BG8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WMDdWxN3Qb7XFNpqwoEt+4FLR5646guO2CIRunMe43aDmRHp6G107TUGAAumjG0DLfM0qlbeUbY82Ky235hD/nB8u6IvwMF3cw4XvJ3xysdL8All2MJpfl2A8TfoVqxixZMRv1uKOXU9BPeeTX/DRIqLxreKhdvsJE7hr0V02Yg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=l8Rftvs+; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="l8Rftvs+" Received: from [192.168.0.43] (cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 92B5920FF; Mon, 30 Mar 2026 09:49:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1774856951; bh=r6tj4wjTcXuf34OsWonOEaYIh+C+DzYKxkZwDt53BG8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=l8Rftvs+UODMSV/R/G6vvRNnlBa5hXGlT6PedFdIU5NqkZbU1tSevAw1KTOQMud4r N6i2PTVyWEIW8BFHHGVFObayGihe3J0bDD28cgTS/wCV/ka+eBSz5D2BEfj7IIGN5P zMapbzgGbQWwok/1KSWvjo2CLu+pmCiKHwEdeFPc= Message-ID: Date: Mon, 30 Mar 2026 08:50:28 +0100 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/14] media: rzg2l-cru: Do not use irqsave when not needed To: Jacopo Mondi , Mauro Carvalho Chehab , Laurent Pinchart , Biju Das , Hans Verkuil , Sakari Ailus , Tommaso Merciai Cc: =?UTF-8?Q?Barnab=C3=A1s_P=C5=91cze?= , Lad Prabhakar , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jacopo Mondi References: <20260327-b4-cru-rework-v1-0-3b7d0430f538@ideasonboard.com> <20260327-b4-cru-rework-v1-6-3b7d0430f538@ideasonboard.com> Content-Language: en-US From: Dan Scally In-Reply-To: <20260327-b4-cru-rework-v1-6-3b7d0430f538@ideasonboard.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 27/03/2026 17:10, Jacopo Mondi wrote: > From: Jacopo Mondi > > The return_unused_buffers() and rzg2l_cru_buffer_queue() functions > are never called from an interrupt context, hence they do not need to > use the irqsave version of the spinlock primitives. > > Signed-off-by: Jacopo Mondi > --- Reviewed-by: Daniel Scally > drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > index 43b1d35fb963..2e94788c3a13 100644 > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > @@ -113,7 +113,7 @@ static void return_unused_buffers(struct rzg2l_cru_dev *cru, > struct rzg2l_cru_buffer *buf, *node; > unsigned int i; > > - guard(spinlock_irqsave)(&cru->qlock); > + guard(spinlock_irq)(&cru->qlock); > > for (i = 0; i < cru->num_buf; i++) { > if (cru->queue_buf[i]) { > @@ -166,7 +166,7 @@ static void rzg2l_cru_buffer_queue(struct vb2_buffer *vb) > struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb); > struct rzg2l_cru_dev *cru = vb2_get_drv_priv(vb->vb2_queue); > > - guard(spinlock_irqsave)(&cru->qlock); > + guard(spinlock_irq)(&cru->qlock); > list_add_tail(to_buf_list(vbuf), &cru->buf_list); > } > >