Re: [PATCH v15 18/19] media: uvcvideo: implement UVC v1.5 ROI

[Gergo Koteles <soyer@irl.hu>]

Hi Ricardo,

On Thu, 2024-11-14 at 19:10 +0000, Ricardo Ribalda wrote:
> 
> +	},
> +	{
> +		.id		= V4L2_CID_UVC_REGION_OF_INTEREST_AUTO,
> +		.entity		= UVC_GUID_UVC_CAMERA,
> +		.selector	= UVC_CT_REGION_OF_INTEREST_CONTROL,
> +		.size		= 16,
> +		.offset		= 64,
> +		.v4l2_type	= V4L2_CTRL_TYPE_BITMASK,
> +		.data_type	= UVC_CTRL_DATA_TYPE_BITMASK,
> +		.name		= "Region Of Interest Auto Controls",
> +	},
>  };
>  

Wouldn't be better to use 8 V4L2_CTRL_TYPE_BOOLEAN controls for this?

Thanks,
Gergo