All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: charles.embedded@gmail.com
Cc: Anshul Dalal <anshulusr@gmail.com>, Shuah Khan <shuah@kernel.org>,
	 Brigham Campbell <me@brighamcampbell.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Charles Dias <charlesdias.cd@outlook.com>
Subject: Re: [PATCH 2/3] Input: adafruit-seesaw - add interrupt support
Date: Sun, 22 Mar 2026 22:12:25 -0700	[thread overview]
Message-ID: <acDLSiujizhuYfOt@google.com> (raw)
In-Reply-To: <20260321202446.724277-3-charles.embedded@gmail.com>

Hi Charles,

On Sat, Mar 21, 2026 at 05:24:45PM -0300, charles.embedded@gmail.com wrote:
> @@ -289,6 +341,19 @@ static int seesaw_probe(struct i2c_client *client)
>  	input_set_max_poll_interval(seesaw->input_dev, SEESAW_GAMEPAD_POLL_MAX);
>  	input_set_min_poll_interval(seesaw->input_dev, SEESAW_GAMEPAD_POLL_MIN);
>  
> +	if (client->irq) {
> +		err = seesaw_register_write_u32(client, SEESAW_GPIO_INTENSET, SEESAW_BUTTON_MASK);
> +		if (err)
> +			return dev_err_probe(&client->dev, err,
> +						"failed to enable hardware interrupts\n");

Maybe this should be in seesaw_open()?

Thanks.

-- 
Dmitry

  reply	other threads:[~2026-03-23  5:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-21 20:24 [PATCH 0/3] Input: adafruit-seesaw: use dev_err_probe and add IRQ support charles.embedded
2026-03-21 20:24 ` [PATCH 1/3] Input: adafruit-seesaw - switch to using dev_err_probe() charles.embedded
2026-03-21 20:24 ` [PATCH 2/3] Input: adafruit-seesaw - add interrupt support charles.embedded
2026-03-23  5:12   ` Dmitry Torokhov [this message]
2026-03-24 13:59     ` Charles Dias
2026-04-19 19:24       ` Charles Dias
2026-05-22 20:32         ` Charles Dias
2026-03-21 20:24 ` [PATCH 3/3] dt-bindings: input: adafruit-seesaw-gamepad: fix interrupt polarity charles.embedded

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acDLSiujizhuYfOt@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=anshulusr@gmail.com \
    --cc=charles.embedded@gmail.com \
    --cc=charlesdias.cd@outlook.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@brighamcampbell.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.