Re: Monitor address printing

["Dr. David Alan Gilbert" <dave@treblig.org>]

* Philippe Mathieu-Daudé (philmd@linaro.org) wrote:
> On 23/3/26 10:35, Philippe Mathieu-Daudé wrote:
> > On 23/3/26 10:00, Philippe Mathieu-Daudé wrote:
> > > On 23/3/26 00:38, BALATON Zoltan wrote:
> > > > Hello,
> > > > 
> > > > Noticed that now addresses are printed with a lot of leading
> > > > zeros in monitor:
> > > > 
> > > > $ qemu-system-ppc -monitor stdio -S
> > > > QEMU 10.2.90 monitor - type 'help' for more information
> > > > (qemu) x/x 0
> > > > 0000000000000000000000000000000000000000000000000000000000000000:
> > > > 0x00000000
> > > > (qemu) x/x 0xfff00000
> > > > 00000000000000000000000000000000000000000000000000000000fff00000:
> > > > 0x60000000
> > > 
> > > Likely commit 6ad593a75a8 ("monitor/hmp: Use plain uint64_t @addr
> > > argument in memory_dump()").
> > > 
> > 
> > Thanks for the report, I'll post a patch with a fix similar to:
> > 
> > -- >8 --
> > diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
> > index bad034937a9..59d49b00f7b 100644
> > --- a/monitor/hmp-cmds.c
> > +++ b/monitor/hmp-cmds.c
> > @@ -537,9 +537,11 @@ static void memory_dump(Monitor *mon, int count,
> > int format, int wsize,
> >       uint8_t buf[16];
> >       uint64_t v;
> >       CPUState *cs = mon_get_cpu(mon);
> > -    const unsigned int addr_width = is_physical ? 8 :
> > (target_long_bits() * 2);
> > +    const unsigned int addr_width = is_physical ? 8 :
> > (target_long_bits() / 4);
> >       const bool big_endian = target_big_endian();
> > ---
> 
> Dave had it right during review btw ;)
> https://lore.kernel.org/qemu-devel/aUyC6HNv8KftowlQ@gallifrey/

Haha, only spotted half the confusion!

Dave
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/