From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D11DEC01C9 for ; Mon, 23 Mar 2026 11:19:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AA84210E0C7; Mon, 23 Mar 2026 11:19:09 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 4D6C910E0C7 for ; Mon, 23 Mar 2026 11:19:08 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CA0ED1684 for ; Mon, 23 Mar 2026 04:19:01 -0700 (PDT) Received: from [192.168.0.1] (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 9CF613F885 for ; Mon, 23 Mar 2026 04:19:07 -0700 (PDT) Date: Mon, 23 Mar 2026 11:18:58 +0000 From: Liviu Dudau To: Christian Hewitt Cc: Boris Brezillon , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/panthor: correct firmware related messages Message-ID: References: <20260323081132.3217646-1-christianshewitt@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260323081132.3217646-1-christianshewitt@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Mar 23, 2026 at 08:11:32AM +0000, Christian Hewitt wrote: > Some English language corrections to firmware messages. No > functional changes. > > Signed-off-by: Christian Hewitt Reviewed-by: Liviu Dudau > --- > drivers/gpu/drm/panthor/panthor_fw.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_fw.c b/drivers/gpu/drm/panthor/panthor_fw.c > index a64ec8756bed..349bb6b0e7bf 100644 > --- a/drivers/gpu/drm/panthor/panthor_fw.c > +++ b/drivers/gpu/drm/panthor/panthor_fw.c > @@ -580,7 +580,7 @@ static int panthor_fw_load_section_entry(struct panthor_device *ptdev, > > if (hdr.flags & CSF_FW_BINARY_IFACE_ENTRY_PROT) { > drm_warn(&ptdev->base, > - "Firmware protected mode entry not be supported, ignoring"); > + "Firmware protected mode entry is not supported, ignoring"); > return 0; > } > > @@ -749,7 +749,7 @@ static int panthor_fw_load_entry(struct panthor_device *ptdev, > > if ((iter->offset % sizeof(u32)) || > (CSF_FW_BINARY_ENTRY_SIZE(ehdr) % sizeof(u32))) { > - drm_err(&ptdev->base, "Firmware entry isn't 32 bit aligned, offset=0x%x size=0x%x\n", > + drm_err(&ptdev->base, "Firmware entry is not 32-bit aligned, offset=0x%x size=0x%x\n", > (u32)(iter->offset - sizeof(u32)), CSF_FW_BINARY_ENTRY_SIZE(ehdr)); > return -EINVAL; > } > -- > 2.43.0 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯