All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Mark Brown <broonie@kernel.org>, Frank Li <Frank.Li@nxp.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Heiko Stuebner <heiko@sntech.de>,
	Laxman Dewangan <ldewangan@nvidia.com>,
	linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH 1/5] spi: imx: fix use-after-free on unbind
Date: Mon, 23 Mar 2026 16:41:15 +0100	[thread overview]
Message-ID: <acFfGzBkNPaIj3jv@hovoldconsulting.com> (raw)
In-Reply-To: <20260323-kickass-original-wapiti-a01804-mkl@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]

On Mon, Mar 23, 2026 at 03:47:45PM +0100, Marc Kleine-Budde wrote:
> On 23.03.2026 14:59:49, Johan Hovold wrote:

> > Indeed, it's a known issue with the SPI API. See for example:
> >
> > 	68b892f1fdc4 ("spi: document odd controller reference handling")
> > 	5e844cc37a5c ("spi: Introduce device-managed SPI controller allocation")

> > 	f0c35a024cce ("spi: fix misleading controller deregistration kernel-doc")

This was supposed to say

	3f174274d224 ("spi: fix misleading controller deregistration kernel-doc")

> > > Would using devm_spi_alloc_host() be an option here?
> >
> > It can also be used, but that's more intrusive so I did that as a
> > follow-on cleanup to the fix (see patch 2/5).
> 
> Ah, nice! At the time I replied to the patch, the whole series was not
> available on lore, yet.

Sorry, I should have CC:ed you the whole series.

> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
> 
> And thanks for taking the time in explaining me the details :)

No worries. :)

Johan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 265 bytes --]

  reply	other threads:[~2026-03-23 15:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-23 10:49 [PATCH 0/5] spi: imx: fix use-after-free on unbind Johan Hovold
2026-03-23 10:49 ` [PATCH 1/5] " Johan Hovold
2026-03-23 11:00   ` Marc Kleine-Budde
2026-03-23 11:20     ` Johan Hovold
2026-03-23 11:57       ` Marc Kleine-Budde
2026-03-23 13:59         ` Johan Hovold
2026-03-23 14:47           ` Marc Kleine-Budde
2026-03-23 15:41             ` Johan Hovold [this message]
2026-03-23 10:49 ` [PATCH 2/5] spi: imx: switch to managed controller allocation Johan Hovold
2026-03-23 10:49 ` [PATCH 3/5] spi: tegra20-slink: " Johan Hovold
2026-03-23 10:49 ` [PATCH 4/5] spi: rockchip: fix controller deregistration Johan Hovold
2026-03-23 16:35   ` Mark Brown
2026-03-23 16:51     ` Johan Hovold
2026-03-23 17:02       ` Mark Brown
2026-03-24  8:09         ` Johan Hovold
2026-03-23 10:49 ` [PATCH 5/5] spi: rockchip: switch to managed controller allocation Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acFfGzBkNPaIj3jv@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=Frank.Li@nxp.com \
    --cc=broonie@kernel.org \
    --cc=heiko@sntech.de \
    --cc=ldewangan@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=s.hauer@pengutronix.de \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.