From: Bobby Eshleman <bobbyeshleman@gmail.com>
To: Simon Horman <horms@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Shuah Khan <shuah@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
David Wei <dw@davidwei.uk>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Bobby Eshleman <bobbyeshleman@meta.com>
Subject: Re: [PATCH net] selftests: drv-net: add missing tc config options for netkit tests
Date: Mon, 23 Mar 2026 17:05:01 -0700 [thread overview]
Message-ID: <acHVLQA2eIsLuqEU@syzkaller> (raw)
In-Reply-To: <20260321103607.GA74886@horms.kernel.org>
On Sat, Mar 21, 2026 at 10:36:07AM +0000, Simon Horman wrote:
> On Fri, Mar 20, 2026 at 11:08:35AM -0700, Bobby Eshleman wrote:
> > From: Bobby Eshleman <bobbyeshleman@meta.com>
> >
> > The NetDrvContEnv env context uses tc clsact qdiscs and BPF tc filters
> > for traffic redirection, but the kernel config options are missing from
> > the selftests config.
> >
> > Without them, the tc qdisc installation trips on:
> >
> > CMD: tc qdisc add dev enp1s0 clsact
> > EXIT: 2
> > STDERR: Error: Specified qdisc kind is unknown.
> >
> > net.lib.py.utils.CmdExitFailure: Command failed
> >
> > Add CONFIG_NET_CLS_ACT and CONFIG_NET_SCH_INGRESS to enable these tc
> > options.
> >
> > Fixes: 3f74d5bb807e ("selftests/net: Add env for container based tests")
> > Signed-off-by: Bobby Eshleman <bobbyeshleman@meta.com>
>
> Hi Bobby,
>
> Unfortunately this does not apply cleanly to net.
> Which breaks CI.
>
> Please rebase and repost.
>
> --
> pw-bot: cr
Oh, I see now that 3f74d5bb807e ("selftests/net: Add env for container
based tests") is only in net-next, not net yet.
I'll resend with the proper tag.
Best,
Bobby
prev parent reply other threads:[~2026-03-24 0:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 18:08 [PATCH net] selftests: drv-net: add missing tc config options for netkit tests Bobby Eshleman
2026-03-21 10:36 ` Simon Horman
2026-03-24 0:05 ` Bobby Eshleman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acHVLQA2eIsLuqEU@syzkaller \
--to=bobbyeshleman@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=bobbyeshleman@meta.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.