From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christian Brauner <brauner@kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Zorro Lang <zlang@redhat.com>,
linux-xfs@vger.kernel.org, Tal Zussman <tz2294@columbia.edu>,
axboe@kernel.dk, linux-block@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] iomap: fix lockdep complaint when reads fail
Date: Mon, 23 Mar 2026 23:14:12 -0700 [thread overview]
Message-ID: <acIrtFpASaBmFZPU@infradead.org> (raw)
In-Reply-To: <20260323210017.GL6223@frogsfrogsfrogs>
Please reword the subject - your are not fixing a lockdep complain,
but the underlying issue of calling code from the wrong context.
Lockdeps as usual is just the messenger.
> Zorro's diagnosis makes sense, so the solution is to kick the failed
> read handling to a workqueue much like we added for writeback ioends in
> commit 294f54f849d846 ("fserror: fix lockdep complaint when igrabbing
> inode").
The code looks ok, although I'd much prefer generalizing it. I guess
we're too late in the 7.0-cycle for that, so:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-03-24 6:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 19:43 [Bug][xfstests xfs/556] inconsistent {HARDIRQ-ON-W} -> {IN-HARDIRQ-W} usage Zorro Lang
2026-03-20 7:23 ` Christoph Hellwig
2026-03-20 14:27 ` Darrick J. Wong
2026-03-23 6:15 ` Christoph Hellwig
2026-03-20 16:34 ` Darrick J. Wong
2026-03-21 18:20 ` Zorro Lang
2026-03-23 11:29 ` Zorro Lang
2026-03-23 6:17 ` Christoph Hellwig
2026-03-23 15:22 ` Darrick J. Wong
2026-03-23 21:00 ` [PATCH] iomap: fix lockdep complaint when reads fail Darrick J. Wong
2026-03-24 6:14 ` Christoph Hellwig [this message]
2026-03-25 0:16 ` Jens Axboe
2026-03-24 8:15 ` Christian Brauner
2026-03-24 17:06 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acIrtFpASaBmFZPU@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tz2294@columbia.edu \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.