From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81279E9A768 for ; Tue, 24 Mar 2026 10:55:05 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w4zPR-00088O-8h; Tue, 24 Mar 2026 06:54:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w4zPP-00088D-IM for qemu-devel@nongnu.org; Tue, 24 Mar 2026 06:54:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w4zPN-00011C-VU for qemu-devel@nongnu.org; Tue, 24 Mar 2026 06:54:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774349689; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=rUIgxkZT2yzzsX0JAAuiHF8PjxEoMHU8hBwniQ9EoRw=; b=eO+B+fcwUYvMeWofWhwBjFfeXv2gBw0f2c0Y6eS5mtvhu31jpKcQo4al6NwEsZAZ/zXdXP XA7U6fdzWrsX0smuAtpMvR1yXdfx4Jm2ciTMmzKz6PF7ZAACGBgBvGCy0maIrlcnJkp3cg veySJtcDoaP9KflZiErTxxgvFT3cV/4= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-228-pIEyrAK4PvCcKrtLaQAmYg-1; Tue, 24 Mar 2026 06:54:45 -0400 X-MC-Unique: pIEyrAK4PvCcKrtLaQAmYg-1 X-Mimecast-MFC-AGG-ID: pIEyrAK4PvCcKrtLaQAmYg_1774349685 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B3CE61954B17; Tue, 24 Mar 2026 10:54:44 +0000 (UTC) Received: from redhat.com (unknown [10.44.33.93]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 825E219560B1; Tue, 24 Mar 2026 10:54:42 +0000 (UTC) Date: Tue, 24 Mar 2026 10:54:38 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Junjie Cao Cc: qemu-devel@nongnu.org, peterx@redhat.com, farosas@suse.de Subject: Re: [PATCH v2 0/3] migration/file: fix type mismatch and NULL deref in multifd_file_recv_data Message-ID: References: <20260316084618.52-1-junjie.cao@intel.com> <20260318140113.434-1-junjie.cao@intel.com> <20260324082738.841-1-junjie.cao@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260324082738.841-1-junjie.cao@intel.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Mar 24, 2026 at 04:27:38PM +0800, Junjie Cao wrote: > Hi Peter, Daniel, > > I wanted to follow up on this series. Looking back, I went > straight to adding new public API in io/channel. I should > have confirmed my approach and whether the Suggested-by > tag was appropriate here with you before sending. Sorry for that. > > I see two possible paths and would appreciate your guidance: > > (a) Keep it purely a fix in migration/file.c: add a local > retry loop around qio_channel_pread() in > multifd_file_recv_data(), fix the ssize_t/size_t > mismatch, and use ERRP_GUARD() so error_prepend() > is safe. > > (b) If pread_all() retry helpers are worth having as a > general facility in io/channel, I'm happy to propose > them as a separate RFC so we can discuss the API design > on its own merits. > > I'm leaning toward (a) and can send a v3 quickly. > Does that sound right? Doing (b) is the right approach. We want these helpers in the general code, so we don't create technical debt that has to be fixed next time something else wants the same APIs. With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|