Re: [LTP] [PATCH] vmcp: skip test on non-s390x architectures

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> The vmcp test is specific to s390x systems and is not supported on
> other architectures such as ppc64le. Currently, the test fails on
> unsupported platforms.
> 
> Add an architecture check to skip execution on non-s390x systems
> by reporting TCONF, avoiding false test failures.
> 
> Signed-off-by: Sowmya Indranna <sowmya.indranna@ibm.com>
> ---
>  testcases/commands/vmcp/vmcp_m.sh | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/testcases/commands/vmcp/vmcp_m.sh b/testcases/commands/vmcp/vmcp_m.sh
> index 3924a6e11..e40dec4bd 100644
> --- a/testcases/commands/vmcp/vmcp_m.sh
> +++ b/testcases/commands/vmcp/vmcp_m.sh
> @@ -15,6 +15,15 @@ TST_CNT=2
>  TST_TESTFUNC=vmcp_main
>  TST_NEEDS_CMDS="vmcp"
>  
> +# Check if running on s390x architecture
> +check_arch()
> +{
> +	local arch=$(uname -m)
> +	if [ "$arch" != "s390x" ]; then
> +		tst_brk TCONF "vmcp test requires s390x architecture, current: $arch"
> +	fi
> +}

The test has TST_NEEDS_CMDS="vmcp" it shouldn't even start unless there
is vmcp installed. And would expect that vmcp is not installed unless we
are on s390x.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp