From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F20AF54ACB for ; Tue, 24 Mar 2026 14:53:17 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w537s-000196-3i; Tue, 24 Mar 2026 10:53:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w537p-00018o-Gv for qemu-devel@nongnu.org; Tue, 24 Mar 2026 10:52:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w537n-0001Sw-Jf for qemu-devel@nongnu.org; Tue, 24 Mar 2026 10:52:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774363973; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7/yJ5wa7/pCz6XMVZ+JQNVbE5lH53O+DzPR49n7lP1g=; b=XwZi4zOKIGO9N255EtwHMlBWRnE9O5CVqBVTsG5c3kIrOkuLSjeAR4fuNWuuxZjuUkKl8z Xuab55RXenfrd+PeBViSBxmH1osQMc5D1XFWem4JucXz8FrO8LxLKGYXJChlNbwQohvU75 Bqb/FWLlekCsLsWoFE4GrFyt80sZ7zs= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-411-oBis_fkFNXmYOMw_qUOrlA-1; Tue, 24 Mar 2026 10:52:52 -0400 X-MC-Unique: oBis_fkFNXmYOMw_qUOrlA-1 X-Mimecast-MFC-AGG-ID: oBis_fkFNXmYOMw_qUOrlA_1774363971 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2A95C1956096 for ; Tue, 24 Mar 2026 14:52:51 +0000 (UTC) Received: from redhat.com (unknown [10.44.33.93]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 30ACE19560B1; Tue, 24 Mar 2026 14:52:49 +0000 (UTC) Date: Tue, 24 Mar 2026 14:52:46 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: qemu-devel@nongnu.org Subject: Re: [PATCH 47/60] ui/vnc: report an error for duplicate display id Message-ID: References: <20260317-qemu-vnc-v1-0-48eb1dcf7b76@redhat.com> <20260317-qemu-vnc-v1-47-48eb1dcf7b76@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260317-qemu-vnc-v1-47-48eb1dcf7b76@redhat.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Mar 17, 2026 at 12:51:01PM +0400, Marc-André Lureau wrote: > Returning NULL without setting an error is odd. > > Note that we could make this a programming error too, as the duplicate > check is also done during QemuOpt parsing. IMHO we shouldn't rely on QemuOpts given our general intent to get off QemuOpts to QMP for everything. > > Signed-off-by: Marc-André Lureau > --- > ui/vnc.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Daniel P. Berrangé > > diff --git a/ui/vnc.c b/ui/vnc.c > index 03b99c9e590..2c53c92914b 100644 > --- a/ui/vnc.c > +++ b/ui/vnc.c > @@ -3428,6 +3428,7 @@ VncDisplay *vnc_display_new(const char *id, Error **errp) > VncDisplay *vd; > > if (vnc_display_find(id) != NULL) { > + error_setg(errp, "Display '%s' already exists", id); > return NULL; > } > vd = g_malloc0(sizeof(*vd)); > > -- > 2.53.0 > > With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|