From: Dan Carpenter <dan.carpenter@linaro.org>
To: Linus Walleij <linusw@kernel.org>
Cc: Tom Rini <trini@konsulko.com>,
AKASHI Takahiro <akashi.tkhro@gmail.com>,
Peng Fan <peng.fan@nxp.com>, Alice Guo <alice.guo@nxp.com>,
Marek Vasut <marex@denx.de>, Greg Malysa <malysagreg@gmail.com>,
Michael Trimarchi <michael@amarulasolutions.com>,
Yao Zi <me@ziyao.cc>,
Arturs Artamonovs <arturs.artamonovs@analog.com>,
Anis Chali <chalianis1@gmail.com>,
Nathan Barrett-Morrison <nathan.morrison@timesys.com>,
Paul Barker <paul.barker.ct@bp.renesas.com>,
Utsav Agarwal <utsav.agarwal@analog.com>, Ye Li <ye.li@nxp.com>,
Valentin Caron <valentin.caron@foss.st.com>,
Vinh Nguyen <vinh.nguyen.xz@renesas.com>,
u-boot@lists.denx.de,
Andy Shevchenko <andriy.shevchenko@intel.com>,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
arm-scmi@vger.kernel.org, linux-gpio@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Khaled Ali Ahmed <Khaled.AliAhmed@arm.com>,
Michal Simek <michal.simek@amd.com>,
Cristian Marussi <cristian.marussi@arm.com>
Subject: Re: [PATCH v2 3/4] scmi: pinctrl: add pinctrl driver for SCMI
Date: Tue, 24 Mar 2026 18:07:13 +0300 [thread overview]
Message-ID: <acKooSHo_FB45nYH@stanley.mountain> (raw)
In-Reply-To: <CAD++jLmfRVGGHH1EqMAeSVHVCr1-s2JPyuY_w=2h35_mKUXj2Q@mail.gmail.com>
On Tue, Mar 24, 2026 at 02:19:34PM +0100, Linus Walleij wrote:
> On Wed, Mar 11, 2026 at 8:41 PM Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> > scmi_pinctrl: protocol@19 {
> > reg = <0x19>;
> > pinmux1: pinmux_test {
> > pinmux = <0 1 0xFFFFFFFF 18 1
> > 0 2 0xFFFFFFFF 18 1
> > 0 3 0xFFFFFFFF 18 1>;
> > function = "f_gpio1";
> > groups = "grp_1", "grp_3";
> > };
> > };
> >
> > Under linux the pinctrl subsystem will parse the function and group
> > properties and use that to handle muxing. However, under u-boot the
> > pin muxing is done using the "pinmux" property, which feeds raw SCMI
> > pinctrl PINCTRL_SETTINGS_CONFIGURE commands to the server. The
> > numbers are: selector, identifier, function_id, config_type, and
> > config_value. In the example above, it sets pins 1, 2, and 3 to 1.
> > The linux-kernel ignores this pinmux property.
>
> This whole thing is a bit of a hack and shortcut to make hard things
> simple isn't it?
I'm not disagreeing with you at all, but handling the default pinmux
property is the only mandatory part of a pin controller driver in
u-boot.
regards,
dan carpenter
next prev parent reply other threads:[~2026-03-24 15:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 19:39 [PATCH v2 0/4] u-boot: add SCMI GPIO/Pinctrl support Dan Carpenter
2026-03-11 19:39 ` [PATCH v2 1/4] scmi: pinctrl: add pinctrl message IDs Dan Carpenter
2026-03-11 19:39 ` [PATCH v2 2/4] scmi: update comments for scmi_pinctrl_config_set_in() Dan Carpenter
2026-03-11 19:41 ` [PATCH v2 3/4] scmi: pinctrl: add pinctrl driver for SCMI Dan Carpenter
2026-03-12 9:23 ` Peng Fan
2026-03-24 13:19 ` Linus Walleij
2026-03-24 15:07 ` Dan Carpenter [this message]
2026-03-26 9:30 ` Dan Carpenter
2026-03-11 19:41 ` [PATCH v2 4/4] gpio: scmi: Add gpio_scmi driver Dan Carpenter
2026-03-17 9:05 ` Peng Fan
2026-03-23 3:41 ` Peng Fan
2026-03-23 8:02 ` Andy Shevchenko
2026-03-24 11:40 ` Dan Carpenter
2026-03-24 11:53 ` Andy Shevchenko
2026-03-23 6:20 ` [PATCH v2 0/4] u-boot: add SCMI GPIO/Pinctrl support Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acKooSHo_FB45nYH@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=Khaled.AliAhmed@arm.com \
--cc=akashi.tkhro@gmail.com \
--cc=alice.guo@nxp.com \
--cc=andriy.shevchenko@intel.com \
--cc=arm-scmi@vger.kernel.org \
--cc=arturs.artamonovs@analog.com \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=chalianis1@gmail.com \
--cc=cristian.marussi@arm.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=malysagreg@gmail.com \
--cc=marex@denx.de \
--cc=me@ziyao.cc \
--cc=michael@amarulasolutions.com \
--cc=michal.simek@amd.com \
--cc=nathan.morrison@timesys.com \
--cc=paul.barker.ct@bp.renesas.com \
--cc=peng.fan@nxp.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=utsav.agarwal@analog.com \
--cc=valentin.caron@foss.st.com \
--cc=vincent.guittot@linaro.org \
--cc=vinh.nguyen.xz@renesas.com \
--cc=ye.li@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.