From: Mirko Faina <mroik@delayed.space>
To: Junio C Hamano <gitster@pobox.com>
Cc: Patrick Steinhardt <ps@pks.im>, git@vger.kernel.org
Subject: Re: [PATCH] t4014: fix call to `test_expect_success ()`
Date: Tue, 24 Mar 2026 16:48:35 +0100 [thread overview]
Message-ID: <acKx6yBi-BWUVJcv@exploit> (raw)
In-Reply-To: <xmqq5x6l2q5y.fsf@gitster.g>
On Tue, Mar 24, 2026 at 08:38:49AM -0700, Junio C Hamano wrote:
> Could either of you remind us why "make test" did not catch this?
My bad. At the time when I ran it I simply saw no failing tests and
assumed everything worked fine. Next time I'll check that the actual
name of the test is present in the output.
next prev parent reply other threads:[~2026-03-24 15:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 14:52 [PATCH] t4014: fix call to `test_expect_success ()` Patrick Steinhardt
2026-03-24 15:18 ` Mirko Faina
2026-03-24 15:38 ` Junio C Hamano
2026-03-24 15:48 ` Mirko Faina [this message]
2026-03-24 16:39 ` Junio C Hamano
2026-03-24 17:13 ` Re* " Junio C Hamano
2026-03-24 18:05 ` [PATCH] t6002: make test "set -e" clean Junio C Hamano
2026-03-24 18:13 ` [PATCH] test-lib: catch misspelt 'test_expect_successo' Junio C Hamano
2026-03-24 19:35 ` Jeff King
2026-03-24 19:48 ` Junio C Hamano
2026-03-25 5:46 ` Jeff King
2026-03-24 18:20 ` [PATCH] t0008: make test "set -e" clean Junio C Hamano
2026-03-24 18:32 ` [PATCH] t7450: " Junio C Hamano
2026-03-24 18:38 ` Eric Sunshine
2026-03-24 19:03 ` Junio C Hamano
2026-03-25 7:07 ` Re* [PATCH] t4014: fix call to `test_expect_success ()` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acKx6yBi-BWUVJcv@exploit \
--to=mroik@delayed.space \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.