From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: david@ixit.cz
Cc: Kaustabh Chakraborty <kauschluss@disroot.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
Vincent Huang <vincent.huang@tw.synaptics.com>,
Casey Connolly <casey.connolly@linaro.org>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH v8 1/7] dt-bindings: input: syna,rmi4: Document syna,rmi4-s3706b
Date: Tue, 24 Mar 2026 12:42:57 -0700 [thread overview]
Message-ID: <acLpBXc9Qi5riQO0@google.com> (raw)
In-Reply-To: <20260324-synaptics-rmi4-v8-1-2168d2df68f5@ixit.cz>
On Tue, Mar 24, 2026 at 08:40:34PM +0100, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
>
> Mostly irrelevant for authentic Synaptics touchscreens, but very important
> for applying workarounds to cheap TS knockoffs.
>
> These knockoffs work well with the downstream driver, and since the user
> has no way to distinguish them, later in this patch set, we introduce
> workarounds to ensure they function as well as possible.
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> Documentation/devicetree/bindings/input/syna,rmi4.yaml | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/input/syna,rmi4.yaml b/Documentation/devicetree/bindings/input/syna,rmi4.yaml
> index 8685ef4481f4a..fb4804ac3544d 100644
> --- a/Documentation/devicetree/bindings/input/syna,rmi4.yaml
> +++ b/Documentation/devicetree/bindings/input/syna,rmi4.yaml
> @@ -18,9 +18,14 @@ description: |
>
> properties:
> compatible:
> - enum:
> - - syna,rmi4-i2c
> - - syna,rmi4-spi
> + oneOf:
> + - enum:
> + - syna,rmi4-i2c
> + - syna,rmi4-spi
> + - items:
> + - enum:
> + - syna,rmi4-s3706b # OnePlus 6/6T
I thought that all the workarounds will be keyed off this new
compatible, but I do not see that. What am I missing?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2026-03-24 19:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 19:40 [PATCH v8 0/7] Input: synaptics-rmi4 - add quirks for third party touchscreen controllers David Heidelberg
2026-03-24 19:40 ` David Heidelberg via B4 Relay
2026-03-24 19:40 ` [PATCH v8 1/7] dt-bindings: input: syna,rmi4: Document syna,rmi4-s3706b David Heidelberg
2026-03-24 19:40 ` David Heidelberg via B4 Relay
2026-03-24 19:42 ` Dmitry Torokhov [this message]
2026-03-25 11:33 ` David Heidelberg
2026-04-07 4:48 ` Dmitry Torokhov
2026-04-08 11:50 ` David Heidelberg
2026-03-24 19:40 ` [PATCH v8 2/7] Input: synaptics-rmi4 - handle duplicate/unknown PDT entries David Heidelberg
2026-03-24 19:40 ` David Heidelberg via B4 Relay
2026-03-24 19:40 ` [PATCH v8 3/7] Input: synaptics-rmi4 - f12: use hardcoded values for aftermarket touch ICs David Heidelberg
2026-03-24 19:40 ` David Heidelberg via B4 Relay
2026-03-24 19:40 ` [PATCH v8 4/7] Input: synaptics-rmi4 - f55: handle zero electrode count David Heidelberg
2026-03-24 19:40 ` David Heidelberg via B4 Relay
2026-03-24 19:40 ` [PATCH v8 5/7] Input: synaptics-rmi4 - don't do unaligned reads in IRQ context David Heidelberg
2026-03-24 19:40 ` David Heidelberg via B4 Relay
2026-03-24 19:40 ` [PATCH v8 6/7] Input: synaptics-rmi4 - read product ID on aftermarket touch ICs David Heidelberg
2026-03-24 19:40 ` David Heidelberg via B4 Relay
2026-03-24 19:40 ` [PATCH v8 7/7] Input: synaptics-rmi4 - support fallback values for PDT descriptor bytes David Heidelberg
2026-03-24 19:40 ` David Heidelberg via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acLpBXc9Qi5riQO0@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=Jason@zx2c4.com \
--cc=casey.connolly@linaro.org \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=kauschluss@disroot.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=vincent.huang@tw.synaptics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.