All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Leo Martins <loemra.dev@gmail.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com, fstests@vger.kernel.org
Subject: Re: [PATCH] generic/301: skip extent count check on btrfs
Date: Tue, 24 Mar 2026 22:48:48 -0700	[thread overview]
Message-ID: <acN3QEpx_YZZN5Qb@infradead.org> (raw)
In-Reply-To: <c56960b514baf810f2929b5e955a966d9955c468.1774383226.git.loemra.dev@gmail.com>

On Tue, Mar 24, 2026 at 01:40:00PM -0700, Leo Martins wrote:
> +# btrfs CoW extent allocation depends on transaction commit frequency and
> +# metadata reservation behavior, so the 2/3 fragmentation threshold (designed
> +# for XFS cowextsize) is not applicable.

It really is a quality of implementation issue and not specifically
designed for XFS.  But I gues it is hard to force quality of
implementation on specific file systems.

> +if [ "$FSTYP" != "btrfs" ]; then
> +	test $new_extents -lt $((internal_blks * 2 / 3)) || echo "file2 badly fragmented"

Please break the echo into a separate line to keep this readable,
either by just breaking using \ or by turning this into a proper if
statement.


  parent reply	other threads:[~2026-03-25  5:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-24 20:40 [PATCH] generic/301: skip extent count check on btrfs Leo Martins
2026-03-24 20:49 ` Darrick J. Wong
2026-03-24 21:07 ` Qu Wenruo
2026-03-25  5:48 ` Christoph Hellwig [this message]
2026-03-31 20:06   ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acN3QEpx_YZZN5Qb@infradead.org \
    --to=hch@infradead.org \
    --cc=fstests@vger.kernel.org \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=loemra.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.