All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gopi Krishna Menon <krishnagopi487@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: sre@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	lee@kernel.org,  conor+dt@kernel.org, daniel.baluta@nxp.com,
	simona.toaca@nxp.com, d-gole@ti.com,  m-chawdhry@ti.com,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: reset: st: convert to dtschema
Date: Wed, 25 Mar 2026 17:34:07 +0530	[thread overview]
Message-ID: <acPMx9NZBehAzkBp@toolbx> (raw)
In-Reply-To: <20260325-speedy-amethyst-beaver-08a3a4@quoll>

On Wed, Mar 25, 2026 at 12:39:36PM +0100, Krzysztof Kozlowski wrote:

> On Tue, Mar 24, 2026 at 09:29:30PM +0530, Gopi Krishna Menon wrote:
> > Convert the STiH4xx reset controller bindings to DT schema.
> > 
> > Suggested-by: Daniel Baluta <daniel.baluta@nxp.com>
> > Suggested-by: Dhruva Gole <d-gole@ti.com>
> 
> Both suggested you to write this patch?
> 
Hi Krzysztof,

Thanks for the review, They helped me to improve the PATCH,

- Dhruva suggested me to change the subject from dt-bindings: power:
  reset: st: convert to dtschema to dt-bindings: reset: st: convert to
  dtschema as that was the general trend followed with similar files.
- Daniel suggested me to use the word 'reset' instead of 'restart' in
  the patch (whereever possible) as that is more accurate here.

That's why I added those Suggested-by tags.

> > Signed-off-by: Gopi Krishna Menon <krishnagopi487@gmail.com>
> > ---
> > Note:
> > * This patch is part of the GSoC2026 application process for device tree bindings conversions
> > * https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings
> > 
> >  .../power/reset/st,stih407-restart.yaml       | 31 +++++++++++++++++++
> >  .../bindings/power/reset/st-reset.txt         | 11 -------
> >  2 files changed, 31 insertions(+), 11 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/power/reset/st,stih407-restart.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/power/reset/st-reset.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/power/reset/st,stih407-restart.yaml b/Documentation/devicetree/bindings/power/reset/st,stih407-restart.yaml
> > new file mode 100644
> > index 000000000000..d7adbc00f5c3
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/reset/st,stih407-restart.yaml
> > @@ -0,0 +1,31 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/power/reset/st,stih407-restart.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: ST SW reset controller
> > +
> > +maintainers:
> > +  - Lee Jones <lee@kernel.org>
> > +
> > +properties:
> > +  compatible:
> > +    const: st,stih407-restart
> > +
> > +  st,syscfg:
> > +    description: phandle of the syscfg node
> > +    $ref: /schemas/types.yaml#/definitions/phandle
> > +
> > +required:
> > +  - compatible
> > +  - st,syscfg
> > +
> > +unevaluatedProperties: false
> 
> additionalProperties instead
> 
Ok will send a V2 for this.
> 
> Best regards,
> Krzysztof
> 
Thanks,
Gopi Krishna Menon

  reply	other threads:[~2026-03-25 12:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-24 15:59 [PATCH] dt-bindings: reset: st: convert to dtschema Gopi Krishna Menon
2026-03-25 11:39 ` Krzysztof Kozlowski
2026-03-25 12:04   ` Gopi Krishna Menon [this message]
2026-03-25 12:36     ` Krzysztof Kozlowski
2026-03-25 13:13       ` Gopi Krishna Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acPMx9NZBehAzkBp@toolbx \
    --to=krishnagopi487@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=d-gole@ti.com \
    --cc=daniel.baluta@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=m-chawdhry@ti.com \
    --cc=robh@kernel.org \
    --cc=simona.toaca@nxp.com \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.