From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1F54109C022 for ; Wed, 25 Mar 2026 14:27:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0EFB510E208; Wed, 25 Mar 2026 14:27:03 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="TGotR7IG"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7098C10E208 for ; Wed, 25 Mar 2026 14:27:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774448821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KWGD4hQPLoVQRo9t8LEnKi+4d5KyybuIU/ivYgViFIE=; b=TGotR7IGs3XtEiyySecWCTKPSQ8MMzYv7NlIQ0UcfFY83yyqqwWC20lwIoNMY5JRhqC1Lf 3LwspSmgfoErMTQSboFzVP/Pr6+8Hmo9mSO1Q+VgQUd1tYbkp2WsvEggtDMxMqWI+/Zm8/ ScndF1iQuLUDCqkRcqUZTiM/V/2FIVI= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-395-pNIUU-yNMxGcBJ69cvOGgA-1; Wed, 25 Mar 2026 10:26:59 -0400 X-MC-Unique: pNIUU-yNMxGcBJ69cvOGgA-1 X-Mimecast-MFC-AGG-ID: pNIUU-yNMxGcBJ69cvOGgA_1774448819 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-89c514077a6so391698396d6.1 for ; Wed, 25 Mar 2026 07:26:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774448819; x=1775053619; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=KWGD4hQPLoVQRo9t8LEnKi+4d5KyybuIU/ivYgViFIE=; b=WgzB0UU9bLMcrRKPNrdLcfbKRN2RzjOgfuvtt8xoL4hRlqYnK+ECeLm1uOF9Id/KJR Sivc9/3e06KuT65dqo7+29bsAfYamzMqKFZg10FTuXkMUlHgjTmlX3NvkAgCbXriLkxZ AFuwAlfce4i6LqZsjzdvWwiKOyhd4+emRb0xx+gZKbr2VUNdDv1+ZXPltUEmMl48Iprn s/7TM4WGF/hIV1hIOJ4sxfDyb6eagua1jrJloQ8bv0a/19UR8pY3thZQP+q9uIN1GAPi N7wek3vyaW8Bz8GjajMg/jikNzg+K0qoiKbo3ReOm+y/lr+HhS+bi+pmKnNVhjT+Wiuv jnaA== X-Forwarded-Encrypted: i=1; AJvYcCXqrpDw0MQDTyjVZpDmeRedIbv2okY3521U9c4mX05CABxDsoUeYM/KueHdpin7BtfrIuIvIbM2Who=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yx9pbyK4SsiHETQf782bOoFTJzlDfrFk8X6ZLJ2klqW7TC/Jqan smWy2Rg1YG7D4fO2NKkTbBtIo3ydaeMOylHTx6OAcaowlXXrP8pwCfC+c3U/6pM/7CQB+5aCiIb h4xB0yFp+E8fsp91DD52Zo2eY24kXuH2OaHh7JMnBT4aFc8quPVa8g+5OyZr50pJKXgIaqA== X-Gm-Gg: ATEYQzw0JygtCh/GGQGGwxZ4Dgn94l184xvG/cctEpZDm6XYAqCAmmave7dTj9PP1Ly C9Qb63IsaFmE8HCKOnPaJgS8SjexdCkln1iahalaXuouv7bwVLXk+zVbsID7omJis0jCjtbUxr7 oD1Favo2kyL8P6b1sDPIEwWGnU1Q1da0rcrEI2yNDuxNIemHlQmHt+Z5WBd4sveSbwB8RCYsDkt 03liKJIZSRCHRjQS5ARgh+EWRe2zLHEvd9D283MDI+sme1Z2TxKCWGh8bhe0En7y1/8EHvFAARZ kXJ6n9vs7GeYoYnpScqFETCgcOOHzvY60CL64N7Y2QHDVqAIG1um2t+zHY3AP7mBQOqkbkpUzpK 7gxtrWi0nEqkMEp6qBKBXH45xSVP7Trj9baplrkseGMWv2MPOuu5U8Cwv X-Received: by 2002:a05:6214:319e:b0:89a:b20:9f4e with SMTP id 6a1803df08f44-89cc4a445a8mr52199426d6.17.1774448818341; Wed, 25 Mar 2026 07:26:58 -0700 (PDT) X-Received: by 2002:a05:6214:319e:b0:89a:b20:9f4e with SMTP id 6a1803df08f44-89cc4a445a8mr52198596d6.17.1774448817701; Wed, 25 Mar 2026 07:26:57 -0700 (PDT) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89cad854addsm68276376d6.48.2026.03.25.07.26.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 07:26:56 -0700 (PDT) Date: Wed, 25 Mar 2026 10:26:54 -0400 From: Brian Masney To: Chen-Yu Tsai Cc: Stephen Boyd , Matthias Brugger , AngeloGioacchino Del Regno , Frank Binns , Matt Coster , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Icenowy Zheng , Icenowy Zheng , David Airlie , Simona Vetter , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/5] clk: mediatek: Add mt8173-mfgtop driver Message-ID: References: <20260325071951.544031-1-wenst@chromium.org> <20260325071951.544031-3-wenst@chromium.org> MIME-Version: 1.0 In-Reply-To: <20260325071951.544031-3-wenst@chromium.org> User-Agent: Mutt/2.3.0 (2026-01-25) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 1dLeccQjIw6KxLG3fF0EXpbzplqsHdIniRkBcyLQhBQ_1774448819 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Mar 25, 2026 at 03:19:46PM +0800, Chen-Yu Tsai wrote: > The MFG (GPU) block on the MT8173 has a small glue layer, named MFG_TOP > in the datasheet, that contains clock gates, some power sequence signal > delays, and other unknown registers that get toggled when the GPU is > powered on. > > The clock gates are exposed as clocks provided by a clock controller, > while the power sequencing bits are exposed as one singular power domain. > > Signed-off-by: Chen-Yu Tsai > --- > Changes since v1: > - Reduce tab after GATE_MFG() by one tab > - Move of_match_clk_mt8173_mfgtop to just before clk_mt8173_mfgtop_drv > - Rename power domain to "mfg-top" > - Add FORCE_ABORT and ACTIVE_PWRCTL_EN bits and explicitly clear > ACTIVE_PWRCTL_EN bit > --- > drivers/clk/mediatek/Kconfig | 9 + > drivers/clk/mediatek/Makefile | 1 + > drivers/clk/mediatek/clk-mt8173-mfgtop.c | 243 +++++++++++++++++++++++ > 3 files changed, 253 insertions(+) > create mode 100644 drivers/clk/mediatek/clk-mt8173-mfgtop.c > > diff --git a/drivers/clk/mediatek/Kconfig b/drivers/clk/mediatek/Kconfig > index 2c09fd729bab..8dbd9f14be62 100644 > --- a/drivers/clk/mediatek/Kconfig > +++ b/drivers/clk/mediatek/Kconfig > @@ -537,6 +537,15 @@ config COMMON_CLK_MT8173_IMGSYS > help > This driver supports MediaTek MT8173 imgsys clocks. > > +config COMMON_CLK_MT8173_MFGTOP > + tristate "Clock and power driver for MediaTek MT8173 mfgtop" > + depends on COMMON_CLK_MT8173 > + default COMMON_CLK_MT8173 > + select PM_GENERIC_DOMAINS > + select PM_GENERIC_DOMAINS_OF > + help > + This driver supports MediaTek MT8173 mfgtop clocks and power domain. > + > config COMMON_CLK_MT8173_MMSYS > tristate "Clock driver for MediaTek MT8173 mmsys" > depends on COMMON_CLK_MT8173 > diff --git a/drivers/clk/mediatek/Makefile b/drivers/clk/mediatek/Makefile > index d8736a060dbd..892a54eeb281 100644 > --- a/drivers/clk/mediatek/Makefile > +++ b/drivers/clk/mediatek/Makefile > @@ -82,6 +82,7 @@ obj-$(CONFIG_COMMON_CLK_MT8167_VDECSYS) += clk-mt8167-vdec.o > obj-$(CONFIG_COMMON_CLK_MT8173) += clk-mt8173-apmixedsys.o clk-mt8173-infracfg.o \ > clk-mt8173-pericfg.o clk-mt8173-topckgen.o > obj-$(CONFIG_COMMON_CLK_MT8173_IMGSYS) += clk-mt8173-img.o > +obj-$(CONFIG_COMMON_CLK_MT8173_MFGTOP) += clk-mt8173-mfgtop.o > obj-$(CONFIG_COMMON_CLK_MT8173_MMSYS) += clk-mt8173-mm.o > obj-$(CONFIG_COMMON_CLK_MT8173_VDECSYS) += clk-mt8173-vdecsys.o > obj-$(CONFIG_COMMON_CLK_MT8173_VENCSYS) += clk-mt8173-vencsys.o > diff --git a/drivers/clk/mediatek/clk-mt8173-mfgtop.c b/drivers/clk/mediatek/clk-mt8173-mfgtop.c > new file mode 100644 > index 000000000000..9e18f34166ae > --- /dev/null > +++ b/drivers/clk/mediatek/clk-mt8173-mfgtop.c > @@ -0,0 +1,243 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2024 Google LLC > + * Author: Chen-Yu Tsai > + * > + * Based on driver in downstream ChromeOS v5.15 kernel. > + * > + * Copyright (c) 2014 MediaTek Inc. > + * Author: Chiawen Lee > + */ > + > +#include > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "clk-gate.h" > +#include "clk-mtk.h" > + > +static const struct mtk_gate_regs mfg_cg_regs = { > + .sta_ofs = 0x0000, > + .clr_ofs = 0x0008, > + .set_ofs = 0x0004, > +}; > + > +#define GATE_MFG(_id, _name, _parent, _shift, _flags) \ > + GATE_MTK_FLAGS(_id, _name, _parent, &mfg_cg_regs, _shift, &mtk_clk_gate_ops_setclr, _flags) > + > +/* TODO: The block actually has dividers for the core and mem clocks. */ > +static const struct mtk_gate mfg_clks[] = { > + GATE_MFG(CLK_MFG_AXI, "mfg_axi", "axi_mfg_in_sel", 0, CLK_SET_RATE_PARENT), > + GATE_MFG(CLK_MFG_MEM, "mfg_mem", "mem_mfg_in_sel", 1, CLK_SET_RATE_PARENT), > + GATE_MFG(CLK_MFG_G3D, "mfg_g3d", "mfg_sel", 2, CLK_SET_RATE_PARENT), > + GATE_MFG(CLK_MFG_26M, "mfg_26m", "clk26m", 3, 0), > +}; > + > +static const struct mtk_clk_desc mfg_desc = { > + .clks = mfg_clks, > + .num_clks = ARRAY_SIZE(mfg_clks), > +}; > + > +struct mt8173_mfgtop_data { > + struct clk_hw_onecell_data *clk_data; > + struct regmap *regmap; > + struct generic_pm_domain genpd; > + struct of_phandle_args parent_pd, child_pd; > + struct clk *clk_26m; > +}; > + > +/* Delay count in clock cycles */ > +#define MFG_ACTIVE_POWER_CON0 0x24 > + #define RST_B_DELAY_CNT GENMASK(7, 0) /* pwr_rst_b de-assert delay during power-up */ > + #define CLK_EN_DELAY_CNT GENMASK(15, 8) /* CLK_DIS deassert delay during power-up */ > + #define CLK_DIS_DELAY_CNT GENMASK(23, 16) /* CLK_DIS assert delay during power-down */ > + #define FORCE_ABORT BIT(30) /* write 1 to force abort a power event */ > + #define ACTIVE_PWRCTL_EN BIT(31) /* enable ACTIVE_POWER */ > + > +#define MFG_ACTIVE_POWER_CON1 0x28 > + #define PWR_ON_S_DELAY_CNT GENMASK(7, 0) /* pwr_on_s assert delay during power-up */ > + #define ISO_DELAY_CNT GENMASK(15, 8) /* ISO assert delay during power-down */ > + #define ISOOFF_DELAY_CNT GENMASK(23, 16) /* ISO de-assert delay during power-up */ > + #define RST__DELAY_CNT GENMASK(31, 24) /* pwr_rsb_b assert delay during power-down */ Is the double underscore expected in the name? > + > +static int clk_mt8173_mfgtop_power_on(struct generic_pm_domain *domain) > +{ > + struct mt8173_mfgtop_data *data = container_of(domain, struct mt8173_mfgtop_data, genpd); > + > + /* drives internal power management */ > + clk_prepare_enable(data->clk_26m); > + > + /* Power on/off delays for various signals */ > + regmap_write(data->regmap, MFG_ACTIVE_POWER_CON0, Should the return value of clk_prepare_enable() and regmap_write() be checked? > + FIELD_PREP(RST_B_DELAY_CNT, 77) | > + FIELD_PREP(CLK_EN_DELAY_CNT, 61) | > + FIELD_PREP(CLK_DIS_DELAY_CNT, 60) | > + FIELD_PREP(ACTIVE_PWRCTL_EN, 0)); > + regmap_write(data->regmap, MFG_ACTIVE_POWER_CON1, > + FIELD_PREP(PWR_ON_S_DELAY_CNT, 11) | > + FIELD_PREP(ISO_DELAY_CNT, 68) | > + FIELD_PREP(ISOOFF_DELAY_CNT, 69) | > + FIELD_PREP(RST__DELAY_CNT, 77)); > + > + /* Magic numbers related to core switch sequence and delays */ > + regmap_write(data->regmap, 0xe0, 0x7a710184); > + regmap_write(data->regmap, 0xe4, 0x835f6856); > + regmap_write(data->regmap, 0xe8, 0x002b0234); > + regmap_write(data->regmap, 0xec, 0x80000000); > + regmap_write(data->regmap, 0xa0, 0x08000000); > + > + return 0; > +} > + > +static int clk_mt8173_mfgtop_power_off(struct generic_pm_domain *domain) > +{ > + struct mt8173_mfgtop_data *data = container_of(domain, struct mt8173_mfgtop_data, genpd); > + > + /* Magic numbers related to core switch sequence and delays */ > + regmap_write(data->regmap, 0xec, 0); > + > + /* drives internal power management */ > + clk_disable_unprepare(data->clk_26m); > + > + return 0; > +} > + > +static int clk_mt8173_mfgtop_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct device_node *node = dev->of_node; > + struct mt8173_mfgtop_data *data; > + int ret; > + > + data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); > + if (!data) > + return -ENOMEM; > + > + platform_set_drvdata(pdev, data); > + > + data->clk_data = mtk_devm_alloc_clk_data(dev, ARRAY_SIZE(mfg_clks)); > + if (!data->clk_data) > + return -ENOMEM; > + > + /* MTK clock gates also uses regmap */ > + data->regmap = device_node_to_regmap(node); > + if (IS_ERR(data->regmap)) > + return dev_err_probe(dev, PTR_ERR(data->regmap), "Failed to get regmap\n"); > + > + data->child_pd.np = node; > + data->child_pd.args_count = 0; > + ret = of_parse_phandle_with_args(node, "power-domains", "#power-domain-cells", 0, > + &data->parent_pd); > + if (ret) > + return dev_err_probe(dev, ret, "Failed to parse power domain\n"); > + > + devm_pm_runtime_enable(dev); > + /* > + * Do a pm_runtime_resume_and_get() to workaround a possible > + * deadlock between clk_register() and the genpd framework. > + */ > + ret = pm_runtime_resume_and_get(dev); > + if (ret) { > + dev_err_probe(dev, ret, "Failed to runtime resume device\n"); > + goto put_of_node; > + } > + > + ret = mtk_clk_register_gates(dev, node, mfg_clks, ARRAY_SIZE(mfg_clks), > + data->clk_data); > + if (ret) { > + dev_err_probe(dev, ret, "Failed to register clock gates\n"); > + goto put_pm_runtime; > + } > + > + data->clk_26m = clk_hw_get_clk(data->clk_data->hws[CLK_MFG_26M], "26m"); > + if (IS_ERR(data->clk_26m)) { > + dev_err_probe(dev, PTR_ERR(data->clk_26m), "Failed to get 26 MHz clock\n"); > + goto unregister_clks; > + } > + > + ret = of_clk_add_hw_provider(node, of_clk_hw_onecell_get, data->clk_data); > + if (ret) { > + dev_err_probe(dev, ret, "Failed to add clk OF provider\n"); > + goto put_26m_clk; > + } > + > + data->genpd.name = "mfg-top"; > + data->genpd.power_on = clk_mt8173_mfgtop_power_on; > + data->genpd.power_off = clk_mt8173_mfgtop_power_off; > + ret = pm_genpd_init(&data->genpd, NULL, true); > + if (ret) { > + dev_err_probe(dev, ret, "Failed to add power domain\n"); > + goto del_clk_provider; > + } > + > + ret = of_genpd_add_provider_simple(node, &data->genpd); > + if (ret) { > + dev_err_probe(dev, ret, "Failed to add power domain OF provider\n"); > + goto remove_pd; > + } > + > + ret = of_genpd_add_subdomain(&data->parent_pd, &data->child_pd); > + if (ret) { > + dev_err_probe(dev, ret, "Failed to link PM domains\n"); > + goto del_pd_provider; > + } > + > + pm_runtime_put(dev); > + return 0; > + > +del_pd_provider: > + of_genpd_del_provider(node); > +remove_pd: > + pm_genpd_remove(&data->genpd); > +del_clk_provider: > + of_clk_del_provider(node); > +put_26m_clk: > + clk_put(data->clk_26m); > +unregister_clks: > + mtk_clk_unregister_gates(mfg_clks, ARRAY_SIZE(mfg_clks), data->clk_data); > +put_pm_runtime: > + pm_runtime_put(dev); > +put_of_node: > + of_node_put(data->parent_pd.np); > + return ret; > +} > + > +static void clk_mt8173_mfgtop_remove(struct platform_device *pdev) > +{ > + struct mt8173_mfgtop_data *data = platform_get_drvdata(pdev); > + struct device_node *node = pdev->dev.of_node; > + > + of_genpd_remove_subdomain(&data->parent_pd, &data->child_pd); > + of_genpd_del_provider(node); > + pm_genpd_remove(&data->genpd); > + of_clk_del_provider(node); > + clk_put(data->clk_26m); > + mtk_clk_unregister_gates(mfg_clks, ARRAY_SIZE(mfg_clks), data->clk_data); > +} > + > +static const struct of_device_id of_match_clk_mt8173_mfgtop[] = { > + { .compatible = "mediatek,mt8173-mfgtop", .data = &mfg_desc }, Is the match data and mfg_desc used? Brian > + { /* sentinel */ } > +}; > +MODULE_DEVICE_TABLE(of, of_match_clk_mt8173_mfgtop); > + > +static struct platform_driver clk_mt8173_mfgtop_drv = { > + .probe = clk_mt8173_mfgtop_probe, > + .remove = clk_mt8173_mfgtop_remove, > + .driver = { > + .name = "clk-mt8173-mfgtop", > + .of_match_table = of_match_clk_mt8173_mfgtop, > + }, > +}; > +module_platform_driver(clk_mt8173_mfgtop_drv); > + > +MODULE_DESCRIPTION("MediaTek MT8173 mfgtop clock driver"); > +MODULE_LICENSE("GPL"); > -- > 2.53.0.1018.g2bb0e51243-goog >