From: Mike Rapoport <rppt@kernel.org>
To: "David Hildenbrand (Arm)" <david@kernel.org>
Cc: Jianhui Zhou <jianhuizzzzz@gmail.com>,
SeongJae Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
jane.chu@oracle.com, Muchun Song <muchun.song@linux.dev>,
Oscar Salvador <osalvador@suse.de>, Peter Xu <peterx@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
Hugh Dickins <hughd@google.com>,
Sidhartha Kumar <sidhartha.kumar@oracle.com>,
Jonas Zhou <jonaszhou@zhaoxin.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org,
syzbot+f525fd79634858f478e7@syzkaller.appspotmail.com
Subject: Re: [PATCH v4] mm/userfaultfd: fix hugetlb fault mutex hash calculation
Date: Wed, 25 Mar 2026 21:08:38 +0200 [thread overview]
Message-ID: <acQytk1sO0EGBTH5@kernel.org> (raw)
In-Reply-To: <af90838e-bef4-46d6-9bc1-c6185793ea62@kernel.org>
On Wed, Mar 25, 2026 at 09:49:54AM +0100, David Hildenbrand (Arm) wrote:
> On 3/25/26 07:07, Jianhui Zhou wrote:
> > On Tue, Mar 25, 2026 at 01:06:00AM +0000, SeongJae Park wrote:
> >> Seems userfaulfd.c is the only caller of the new helper function. Why don't
> >> you define the function in userfaultfd.c ?
> > I kept hugetlb_linear_page_index() in include/linux/hugetlb.h because
> > this is hugetlb-specific logic, not userfaultfd-specific logic.
>
> Yes, and see my comment about either removing it entirely again next, or
> actually also using it in hugetlb.c.
I think it's better to move large piece of mfill_atomic_hugetlb() to
hugetlb.c and git rid of the helper then.
And now keep it simple for easier backporting.
> --
> Cheers,
>
> David
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2026-03-25 19:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 14:03 [PATCH] mm/userfaultfd: fix hugetlb fault mutex hash calculation Jianhui Zhou
2026-03-06 16:53 ` Peter Xu
2026-03-07 13:37 ` 周建辉
2026-03-07 13:59 ` Jianhui Zhou
2026-03-07 3:27 ` SeongJae Park
2026-03-08 13:41 ` Jianhui Zhou
2026-03-08 22:57 ` SeongJae Park
2026-03-07 14:35 ` [PATCH v2] " Jianhui Zhou
2026-03-09 2:08 ` Hugh Dickins
2026-03-09 3:08 ` Jianhui Zhou
2026-03-09 16:47 ` David Hildenbrand (Arm)
2026-03-10 10:24 ` Jianhui Zhou
2026-03-09 3:30 ` [PATCH v3] " Jianhui Zhou
2026-03-10 11:05 ` [PATCH v4] " Jianhui Zhou
2026-03-10 19:47 ` jane.chu
2026-03-11 10:54 ` Jianhui Zhou
2026-03-25 0:03 ` Andrew Morton
2026-03-25 1:06 ` SeongJae Park
2026-03-25 6:07 ` Jianhui Zhou
2026-03-25 8:49 ` David Hildenbrand (Arm)
2026-03-25 19:08 ` Mike Rapoport [this message]
2026-03-25 8:49 ` David Hildenbrand (Arm)
2026-03-25 19:02 ` Mike Rapoport
2026-03-25 23:46 ` jane.chu
2026-03-26 9:18 ` David Hildenbrand (Arm)
2026-03-25 19:10 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acQytk1sO0EGBTH5@kernel.org \
--to=rppt@kernel.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=hughd@google.com \
--cc=jane.chu@oracle.com \
--cc=jianhuizzzzz@gmail.com \
--cc=jonaszhou@zhaoxin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
--cc=peterx@redhat.com \
--cc=sidhartha.kumar@oracle.com \
--cc=sj@kernel.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+f525fd79634858f478e7@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.