From: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Damien Le Moal <dlemoal@kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH] block/044, scsi/012: Add tests for support for segments smaller than the page size
Date: Thu, 26 Mar 2026 08:05:56 +0000 [thread overview]
Message-ID: <acTocO4Bm-eAo1Ag@shinmob> (raw)
In-Reply-To: <acPFQ3laJg0MDRSM@shinmob>
On Mar 25, 2026 / 20:52, Shin'ichiro Kawasaki wrote:
> On Mar 23, 2026 / 13:07, Bart Van Assche wrote:
> > Linux kernel commit 889c57066cee ("block: make segment size limit workable
> > for > 4K PAGE_SIZE") was merged about one year ago and adds support for
> > DMA segments that are smaller than the virtual memory page size. This is
> > important for devices that do not support DMA segments larger. This patch
> > tests the code paths added by that Linux kernel commit.
> >
> > Cc: Ming Lei <ming.lei@redhat.com>
> > Signed-off-by: Bart Van Assche <bvanassche@acm.org>
>
> Hi Bart, thanks for the patch. Please find my comments in line.
>
> I think it's fine to keep the two new testcases in this single patch, but if
> the kernel side patches go into upstream in different timings, it would be the
> better to separate this patch into two patches for each testcase.
Today, I reran the new testcases and noticed they leave fio verify state files
in the current directory. It would be the better to add --verify_state_save=0
option, or use _run_fio_verify_io() helper function in common/fio.
next prev parent reply other threads:[~2026-03-26 8:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 20:07 [PATCH] block/044, scsi/012: Add tests for support for segments smaller than the page size Bart Van Assche
2026-03-25 11:52 ` Shinichiro Kawasaki
2026-03-26 8:05 ` Shinichiro Kawasaki [this message]
2026-03-26 17:41 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acTocO4Bm-eAo1Ag@shinmob \
--to=shinichiro.kawasaki@wdc.com \
--cc=bvanassche@acm.org \
--cc=dlemoal@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.