From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maarten Lankhorst <dev@lankhorst.se>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [PATCH] drm/xe: Remove useless comment.
Date: Thu, 26 Mar 2026 15:14:42 +0200 [thread overview]
Message-ID: <acUxQpoZRVwPfQpr@intel.com> (raw)
In-Reply-To: <20260326121818.122401-2-dev@lankhorst.se>
On Thu, Mar 26, 2026 at 01:18:14PM +0100, Maarten Lankhorst wrote:
> Commit 792d2b9a1259 ("drm: drop mtrr from i915"), added this comment,
> drop it since it was carried over from i915.
>
> Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
> ---
> drivers/gpu/drm/xe/xe_device.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index e77a3a3db73db..94629d782d07d 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -388,9 +388,6 @@ bool xe_is_xe_file(const struct file *file)
> }
>
> static struct drm_driver driver = {
> - /* Don't use MTRRs here; the Xserver or userspace app should
> - * deal with them for Intel hardware.
> - */
The entire DRIVER_USE_MTRR was killed off in 2013 with
commit 281856477cda ("drm: rip out drm_core_has_MTRR checks").
The leftover comment should be deleted from i915 as well.
This one is
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> .driver_features =
> DRIVER_GEM |
> DRIVER_RENDER | DRIVER_SYNCOBJ |
> --
> 2.53.0
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2026-03-26 13:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 12:18 [PATCH] drm/xe: Remove useless comment Maarten Lankhorst
2026-03-26 12:53 ` ✓ CI.KUnit: success for " Patchwork
2026-03-26 13:14 ` Ville Syrjälä [this message]
2026-03-26 13:27 ` ✓ Xe.CI.BAT: " Patchwork
2026-03-27 3:04 ` ✓ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acUxQpoZRVwPfQpr@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dev@lankhorst.se \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.