From: Bjorn Andersson <andersson@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Cc: konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: monaco: extend fastrpc compute cb
Date: Thu, 26 Mar 2026 08:24:59 -0500 [thread overview]
Message-ID: <acUzKYUCbUOIOrw2@baldur> (raw)
In-Reply-To: <20260326125834.2758331-1-srinivas.kandagatla@oss.qualcomm.com>
On Thu, Mar 26, 2026 at 12:58:34PM +0000, Srinivas Kandagatla wrote:
> diff --git a/arch/arm64/boot/dts/qcom/monaco.dtsi b/arch/arm64/boot/dts/qcom/monaco.dtsi
[..]
> +
> + compute-cb@b {
That doesn't match the patternProperties "(compute-)?cb@[0-9]*$".
Is the reg an index, or an "address"? Should we use base 10, or should
we fix the yaml?
Regards,
Bjorn
> + compatible = "qcom,fastrpc-compute-cb";
> + reg = <0xb>;
> + iommus = <&apps_smmu 0x19cb 0x0400>;
> + dma-coherent;
> + };
> +
> + compute-cb@c {
> + compatible = "qcom,fastrpc-compute-cb";
> + reg = <0xc>;
> + iommus = <&apps_smmu 0x19cc 0x000>;
> + dma-coherent;
> + };
> };
> };
> };
> --
> 2.47.3
>
next prev parent reply other threads:[~2026-03-26 13:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 12:58 [PATCH] arm64: dts: monaco: extend fastrpc compute cb Srinivas Kandagatla
2026-03-26 13:24 ` Bjorn Andersson [this message]
2026-03-26 15:38 ` Srinivas Kandagatla
2026-03-30 16:01 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acUzKYUCbUOIOrw2@baldur \
--to=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.