From: Kevin Wolf <kwolf@redhat.com>
To: Kostiantyn Kostiuk <kkostiuk@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Yan Vugenfirer" <yvugenfi@redhat.com>
Subject: Re: [PATCH 7/7] meson: Build block_syms and qemu_syms only when enable_modules
Date: Thu, 26 Mar 2026 18:10:54 +0100 [thread overview]
Message-ID: <acVonq8XqzPItFxx@redhat.com> (raw)
In-Reply-To: <20260326160033.68318-8-kkostiuk@redhat.com>
Am 26.03.2026 um 17:00 hat Kostiantyn Kostiuk geschrieben:
> Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
I'm not a meson expert, but the change itself looks ok to me.
However, the commit message is definitely a bit too empty. It should say
why you want to make this change.
Kevin
next prev parent reply other threads:[~2026-03-26 17:11 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 16:00 [PATCH 0/7] Misc changes to allow building with Windows Clang Kostiantyn Kostiuk
2026-03-26 16:00 ` [PATCH 1/7] meson: Use stddef.h instead of unistd.h Kostiantyn Kostiuk
2026-03-26 16:34 ` Peter Maydell
2026-03-27 5:52 ` Paolo Bonzini
2026-03-26 16:00 ` [PATCH 2/7] qom: Use g_ascii_strcasecmp instead of strcasecmp Kostiantyn Kostiuk
2026-03-26 16:46 ` Peter Maydell
2026-03-26 16:00 ` [PATCH 3/7] osdep: Remove unused strings.h Kostiantyn Kostiuk
2026-03-26 16:20 ` Peter Maydell
2026-03-26 16:32 ` Kostiantyn Kostiuk
2026-03-26 16:41 ` Peter Maydell
2026-03-26 18:26 ` Kostiantyn Kostiuk
2026-03-26 19:02 ` Peter Maydell
2026-03-26 16:00 ` [PATCH 4/7] Remove unused dirent.h Kostiantyn Kostiuk
2026-03-26 16:23 ` Peter Maydell
2026-03-27 10:45 ` Paolo Bonzini
2026-03-26 16:00 ` [PATCH 5/7] Remove unused sys/param.h Kostiantyn Kostiuk
2026-03-26 16:17 ` Peter Maydell
2026-03-26 16:22 ` Kostiantyn Kostiuk
2026-03-26 16:26 ` Peter Maydell
2026-03-26 16:00 ` [PATCH 6/7] storage-daemon: use same link arguments as other tools Kostiantyn Kostiuk
2026-03-26 17:05 ` Kevin Wolf
2026-03-26 16:00 ` [PATCH 7/7] meson: Build block_syms and qemu_syms only when enable_modules Kostiantyn Kostiuk
2026-03-26 17:10 ` Kevin Wolf [this message]
2026-03-27 10:47 ` Paolo Bonzini
2026-03-27 11:04 ` Kevin Wolf
2026-03-27 11:10 ` Kostiantyn Kostiuk
2026-03-27 12:31 ` Kevin Wolf
2026-03-26 16:34 ` [PATCH 0/7] Misc changes to allow building with Windows Clang Mohamed Mediouni
2026-03-26 16:37 ` Mohamed Mediouni
2026-03-26 16:43 ` Kostiantyn Kostiuk
2026-03-26 16:48 ` Pierrick Bouvier
2026-03-26 17:11 ` Kostiantyn Kostiuk
2026-03-26 17:38 ` Pierrick Bouvier
2026-03-26 17:44 ` Pierrick Bouvier
2026-03-26 17:47 ` Mohamed Mediouni
2026-03-26 16:45 ` Pierrick Bouvier
2026-03-27 5:54 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acVonq8XqzPItFxx@redhat.com \
--to=kwolf@redhat.com \
--cc=berrange@redhat.com \
--cc=kkostiuk@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=yvugenfi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.