From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010059.outbound.protection.outlook.com [52.101.56.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C49B194A60 for ; Fri, 27 Mar 2026 09:46:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.59 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774604804; cv=fail; b=LAWRcROE2EPxC8gU64qjwY4oj4RBlOux+vrrO2jIi3hoJYe3l8VrYvK4IMD8WFDalBgoFkIih27mUZUYTiNvP76HQjekHtvBh3gIsAI372Y/vTkbdVNRDQ916ndByCbDv+NQ4ONiZjCEAosmqa8uUWImtRxDaDD0mHpHtt9dFuA= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774604804; c=relaxed/simple; bh=Js52YU9T25xRoyYcJW7JUsWnckzrYzggeH7DcAFQ9zM=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=nbLH9M2reuk7iZMLQh3Pxcy2ofbAQ6R7aoP4STHPTUVqFqrnMPGlNu2Hqk3/H6faGEnQi3cA2oG05PLCeimLaqs3dQjh0ehRn/bwco4EY6IJ/TR+F6XrtyFrTuMLVtvsAR1D+r0jIaNsjiYKGFDyfRrXvIXHc86xfWjsDDG8t9w= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=r9YR472b; arc=fail smtp.client-ip=52.101.56.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="r9YR472b" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tugJYnAGDy8Xw6hL9jL5cLuHK9AiM/ac5oWnl9qpH+E6jxlJj8T3u4Iu2Vz2A29zzSGr4gnfIObWISuTJ/fQcZZ55I/mtjD+6jJmnX9fYjFuOnc2bO7iT5YByAJqMCHT6RN51DIEgEXgJt6LeXgjk2sMrYkjU5VyXvATmKUukhixMj0jcPCnfRLps1BbMCvykpKpSkzxZRhUIATFhRx19ToBNn6jj/2aZACREd8lh+WSt4HowXbFOIuzbRDDRZuExlHK1juWrttrzYq6CKJLVZ1Ankalk3DJA2iBMzzZP1TOzJ1vyXMn2gABXF0S+Gu6HPME2oCnterTzavuTM61DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HyODkE4EgmvhRgFcnyx3VyLyT0PI7/tS1Sd+ukgDHhY=; b=R/pdIxFuGZ5fHKpwmPUb4TEG85woEXW7LfrYMpbFmCZHhDCVQDlxYLUWSfEilWxe3YVX9WRnebwcu5H6duDqLfbKE8473rybKYkahykEcOxFQhf5v9m1BgorBuDFYWn20kZTVlDmJLRw8P6gUii3oCRa/Qw+y5bWb6mzPIBk6gP51o45SVfR0qYT96r2lVxOurOPV/jphdX7hjaySNd9fZI3aCpezIJzbD6J/Ac496/O3i0amLHYk4crzv88yuy0Oj7DVy2HOtC+N88wUndupnA/sO8TrO2CXJECKHnUyetjepTelYEqj9PJDGEbm5v/4r5eMstRAOKkbmOni+gLwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HyODkE4EgmvhRgFcnyx3VyLyT0PI7/tS1Sd+ukgDHhY=; b=r9YR472beS1fvSOg3sb0RFSe+RQC2VsrcmRotXFxjXXvZk94IproxmdpNbnCpi4BfxWw9H1eADpwFkp751bUyE+jrpi0ave4QwZmhIfzohF7d6evyBnAvyg1gjzSeBDp7a2psYTI2KMWSbmdiZYNx0fMwNPTQT5l6SAwiUrsPn3TIylh4ziviV/hg/uELCIQkhxV92sdoTr8XAb1hDTYNnQ7bsLbXOrmcaxvTfEzubyAXLNewRVv+q4ypiUmNGy2k9LLSiFuRajK+R7FLGyGKKvSGCN+ueGpIYXS5l+zut93HoZKjfIeBAnD3esAkYf+niFO9me5bVNX8LNOoNTgzw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) by DM4PR12MB5866.namprd12.prod.outlook.com (2603:10b6:8:65::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.8; Fri, 27 Mar 2026 09:46:38 +0000 Received: from LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528]) by LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528%5]) with mapi id 15.20.9769.006; Fri, 27 Mar 2026 09:46:37 +0000 Date: Fri, 27 Mar 2026 10:46:30 +0100 From: Andrea Righi To: Vincent Guittot Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Christian Loehle , Koba Ko , Felix Abecassis , Balbir Singh , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] sched/fair: Prefer fully-idle SMT cores in asym-capacity idle selection Message-ID: References: <20260326151211.1862600-1-arighi@nvidia.com> <20260326151211.1862600-2-arighi@nvidia.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MI1P293CA0008.ITAP293.PROD.OUTLOOK.COM (2603:10a6:290:2::11) To LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR12MB9620:EE_|DM4PR12MB5866:EE_ X-MS-Office365-Filtering-Correlation-Id: f83efefb-48d0-4f2a-73ff-08de8be5bd7e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|366016|1800799024|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: mcFevu60lrIewKjjRzOXS8/6M7Q2OE7Fl5I360E0Cj31CZguc1ZoFhuKMvQhCKglFFMuM6kKU5ghBOMqXpakeFGP4r/6Ui5JXKhh7LcSLFJZ0/yW0s1n+G/Fpq73toZK9ZGqLNdERhpqXZcYRWai+FonhnIhPEekvgnUGAhcXSYLRPDxUmnxq2Rulhby6X+QzbgqSfsb0ty7hzSLdejnv5ArZmebbyOm+I1gMJ8ytqmI8rMr11TxQKuus0RoCK6sPldeuoFBMJafwsgYmVUWOiDtXI9sVLfY84exkCOmwovAPwaiL4lL0qtk7UrVt2Uajv0vWL8oimQdoZG4tVI2fvpnWVJaSUrsjj4DFx1hqcDVn1TEVVBT9SP+ZfI18FOA8Ts8qJ1pOZCv2/wkHVwXIKGm0NodxyOdWS1FRYBpjR35hsC1X3X3QpyOXPA+oudrW3GsrYJy4sVWDIqOhWIRCHLfUwFKDX9TzvLSmwt4iFfqy9LF0Tzqh4D+98BQNsZeI/1fFmGgNqWgelRNq6zy8I9X5PxtinSE4Ejzumsp+B2a5grs1mrUQaY47ycbWMZuS25w6qFyl2B3WYI2qrkJklR3QXvy+UC9pXR+3xtq0atTCYdOko6HwgIPgzkfD8DWAPhhYP57qHSESbY1EiiAn4+ph8uEKDs0/ACNzDMD8lkJXrDfMwgdZ0Y/MKjwWuHpoohtSK2w9qdL1xXfL3fae8PAnklrlN2v6riKpRi8C44= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR12MB9620.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(366016)(1800799024)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NyzQfz+713CE6CQANCA2RgSvYlV9J6p3nsSB5n+gTt4cbAkb3Rz0v7Z83QQ3?= =?us-ascii?Q?SZCYG7o6uIvsQxtMtAYn5lx80ClBKvLRyTw9Oigl6v1fCYYfElJih1n/Px46?= =?us-ascii?Q?Q5MkIggFGgPeurmWjBaU6ik53PQUjYjoRWi4+xdyHd76/JAQhDvVAWOPh6yE?= =?us-ascii?Q?cP8Cff08/DwuZaqORyGt+SrrG5EJQ0i3sbHf25pTTA4GTJcmC4E/sKkf2ST0?= =?us-ascii?Q?IWXAUknIaismPxIFeJmMWgcfxDMQe67Q8qn1fArnql0bKNWAQIdgAAXI+hz2?= =?us-ascii?Q?poMi9POGbkqAOsQr0W3z6ARcKp98slvm3jWQwMivXphCw8V5wRNHNs8yIAqs?= =?us-ascii?Q?H9+jwhPJAlcYMgXnRPXUri9e5ohFC7qPcCT28GTd5WiyOk7hzRYBV6yxPb0s?= =?us-ascii?Q?gzLq7riIosVIhsehJDJRj5n/57kPN5Pn5AMrF9JlbM5a70O2b1tmgxbk0384?= =?us-ascii?Q?hOQl4PqMBDtEmU16uZGSLabatOMfTdFgulcvfaA9G7vKqBK0yyljTYCSKlzj?= =?us-ascii?Q?KE+d1krBDBD/XzfoaS2rjBQiPtzaS0vf9RrmEV1hHIpxfiBm8tGfp4d6ybYT?= =?us-ascii?Q?oRChpE4SAm+3Kwb63YImErgpbIEWUsjJBGsyP+0dLiMIC//uxHxVti5ay7+o?= =?us-ascii?Q?/3Y78xPcsrVbX8Bse5S7rxeHWF+wPWF8hKAlQ4SUvXyK/xVB+BNRYX8sFyMB?= =?us-ascii?Q?PdW4hKSyDa6N40xyKV6wwd6UMwhvSRlahN3RosshNUIhJlxcCCJOPvjhMXC9?= =?us-ascii?Q?QuXgHyQx+yrYAB6FWIOBeDEy7Us0dI3aIKODoebC8XoBi50J513+PYKNvQUt?= =?us-ascii?Q?nNSPtgfug58Ulk9ZaEORIJnsK8aAzm4fTanOjHfN6u3ITnjWT8GVqtFED8kc?= =?us-ascii?Q?l3rI1406tNk4eTtoX7/ondVaDPwIZB2nABuSRpCgF0LObLp/NVAGWZqxEfc1?= =?us-ascii?Q?h5nUtJqoCI+U0GXcPMYPEBC5PmAVL/A8/vJcyhrAC1ypDNvJAbXCWhn6mk/8?= =?us-ascii?Q?eoTt0d4IgPjWeSmHVbV52GJYRhRg4o1k55D6JhTtfIHD7IawYukYuCBDBWp6?= =?us-ascii?Q?5y9STMbt9A8ZeS/cfzq1sxJ93ZI61bgf0vpZuSsli1mo/abeGAo66vZb0fVS?= =?us-ascii?Q?1QtBKxTOyA3x8cN9sPPLQMedtX264msB/zwNylT2RQx/D4O5E8HSuQpI21AX?= =?us-ascii?Q?ecxqm49tBZt8qg2818fuvwI7pWpo8xe0fWOOJ+V3cbEHMpT3WbmuemX6P4i/?= =?us-ascii?Q?rSuNcdoXtOkkfaK0cEwtK3glpx/zbE95wNK4QeOBNa0eHPTapOs/MolxSR2T?= =?us-ascii?Q?TIiv7ABHJglIyXfLQeQUGdfqPhgF1aY8tsOWPSG/pdsC1d6rg6tDw8V3NzTv?= =?us-ascii?Q?YOiKKH4mjIZHtNUzNNQoogfXtvxUvmA4mScshuoSLS8Watxtm7AxQ7BSpz2N?= =?us-ascii?Q?Phmn/FByUi9xzJjXKXKxkk3J4s7l3Accm90mPAJVX/YnvUX/3zTPyQJtqOo0?= =?us-ascii?Q?MNvf9l9dXINl9wLLlKg/RBut1ft7FxMk1I9EW4kfZCQoBEKyHhn3kNwTUO+n?= =?us-ascii?Q?qPExuOUeWXVUTXQzXKYOamceYBcbpquhB2iYi5D12K2ZQrl5SPBSjvt2H4Cu?= =?us-ascii?Q?fkJUnBtBOW2i9VNphKpLhqb9mnJmqM7f3T/ev8hHxIxMi7DXMzNqjWyF5VLl?= =?us-ascii?Q?eBTgNxVUfZSc4ZMmtuTyuA5Xi3sBn3pUHV4mTyCBqdgni0QqPx/0C9TuFp7G?= =?us-ascii?Q?AQ0p5B7lFA=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: f83efefb-48d0-4f2a-73ff-08de8be5bd7e X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9620.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2026 09:46:37.8732 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: igchAG+dVmkAr7HPAzZdo4UvDQov7eKQpDdIHtYkNqPrfGYpr63DorKIb/dCipAITH7RB3GRkddpGvFn+IT3lA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5866 Hi Vincent, On Fri, Mar 27, 2026 at 09:09:24AM +0100, Vincent Guittot wrote: > On Thu, 26 Mar 2026 at 16:12, Andrea Righi wrote: > > > > On systems with asymmetric CPU capacity (e.g., ACPI/CPPC reporting > > different per-core frequencies), the wakeup path uses > > select_idle_capacity() and prioritizes idle CPUs with higher capacity > > for better task placement. However, when those CPUs belong to SMT cores, > > their effective capacity can be much lower than the nominal capacity > > when the sibling thread is busy: SMT siblings compete for shared > > resources, so a "high capacity" CPU that is idle but whose sibling is > > busy does not deliver its full capacity. This effective capacity > > reduction cannot be modeled by the static capacity value alone. > > > > Introduce SMT awareness in the asym-capacity idle selection policy: when > > SMT is active prefer fully-idle SMT cores over partially-idle ones. A > > two-phase selection first tries only CPUs on fully idle cores, then > > falls back to any idle CPU if none fit. > > > > Prioritizing fully-idle SMT cores yields better task placement because > > the effective capacity of partially-idle SMT cores is reduced; always > > preferring them when available leads to more accurate capacity usage on > > task wakeup. > > > > On an SMT system with asymmetric CPU capacities, SMT-aware idle > > selection has been shown to improve throughput by around 15-18% for > > CPU-bound workloads, running an amount of tasks equal to the amount of > > SMT cores. > > > > Cc: Vincent Guittot > > Cc: Dietmar Eggemann > > Cc: Christian Loehle > > Cc: Koba Ko > > Reported-by: Felix Abecassis > > Signed-off-by: Andrea Righi > > --- > > kernel/sched/fair.c | 86 +++++++++++++++++++++++++++++++++++++++------ > > 1 file changed, 75 insertions(+), 11 deletions(-) > > > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > > index d57c02e82f3a1..9a95628669851 100644 > > --- a/kernel/sched/fair.c > > +++ b/kernel/sched/fair.c > > @@ -7940,14 +7940,21 @@ static int select_idle_cpu(struct task_struct *p, struct sched_domain *sd, bool > > * Scan the asym_capacity domain for idle CPUs; pick the first idle one on which > > * the task fits. If no CPU is big enough, but there are idle ones, try to > > * maximize capacity. > > + * > > + * When @prefer_idle_cores is true (asym + SMT and idle cores exist), prefer > > + * CPUs on fully-idle cores over partially-idle ones in a single pass: track > > + * the best candidate among idle-core CPUs and the best among any idle CPU, > > + * then return the idle-core candidate if found, else the best any-idle. > > */ > > static int > > -select_idle_capacity(struct task_struct *p, struct sched_domain *sd, int target) > > +select_idle_capacity(struct task_struct *p, struct sched_domain *sd, int target, > > + bool prefer_idle_cores) > > { > > - unsigned long task_util, util_min, util_max, best_cap = 0; > > - int fits, best_fits = 0; > > - int cpu, best_cpu = -1; > > + unsigned long task_util, util_min, util_max, best_cap = 0, best_cap_core = 0; > > + int fits, best_fits = 0, best_fits_core = 0; > > + int cpu, best_cpu = -1, best_cpu_core = -1; > > struct cpumask *cpus; > > + bool on_idle_core; > > > > cpus = this_cpu_cpumask_var_ptr(select_rq_mask); > > cpumask_and(cpus, sched_domain_span(sd), p->cpus_ptr); > > @@ -7962,16 +7969,58 @@ select_idle_capacity(struct task_struct *p, struct sched_domain *sd, int target) > > if (!choose_idle_cpu(cpu, p)) > > continue; > > > > + on_idle_core = is_core_idle(cpu); > > + if (prefer_idle_cores && !on_idle_core) { > > + /* Track best among any idle CPU for fallback */ > > + fits = util_fits_cpu(task_util, util_min, util_max, cpu); > > fits = util_fits_cpu(task_util, util_min, util_max, cpu); is always > called so call it once above this if condition > > this will help factorize the selection of best_cpu and best_cpu_core Makes sense. > > > + if (fits > 0) { > > + /* > > + * Full fit: strictly better than fits 0 / -1; > > + * among several, prefer higher capacity. > > + */ > > + if (best_cpu < 0 || best_fits <= 0 || > > + (best_fits > 0 && cpu_cap > best_cap)) { > > + best_cap = cpu_cap; > > + best_cpu = cpu; > > + best_fits = fits; > > + } > > + continue; > > + } > > + if (best_fits > 0) > > + continue; > > + if (fits < 0) > > + cpu_cap = get_actual_cpu_capacity(cpu); > > + if ((fits < best_fits) || > > + ((fits == best_fits) && (cpu_cap > best_cap))) { > > + best_cap = cpu_cap; > > + best_cpu = cpu; > > + best_fits = fits; > > + } > > + continue; > > + } > > + > > fits = util_fits_cpu(task_util, util_min, util_max, cpu); > > > > /* This CPU fits with all requirements */ > > - if (fits > 0) > > - return cpu; > > + if (fits > 0) { > > + if (prefer_idle_cores && on_idle_core) > > + return cpu; > > + if (!prefer_idle_cores) > > + return cpu; > > + /* > > + * Prefer idle cores: record and keep looking for > > + * idle-core fit. > > + */ > > + best_cap = cpu_cap; > > + best_cpu = cpu; > > + best_fits = fits; > > + continue; > > + } > > /* > > * Only the min performance hint (i.e. uclamp_min) doesn't fit. > > * Look for the CPU with best capacity. > > */ > > - else if (fits < 0) > > + if (fits < 0) > > cpu_cap = get_actual_cpu_capacity(cpu); > > > > /* > > @@ -7984,8 +8033,17 @@ select_idle_capacity(struct task_struct *p, struct sched_domain *sd, int target) > > best_cpu = cpu; > > best_fits = fits; > > } > > + if (prefer_idle_cores && on_idle_core && > > + ((fits < best_fits_core) || > > + ((fits == best_fits_core) && (cpu_cap > best_cap_core)))) { > > + best_cap_core = cpu_cap; > > + best_cpu_core = cpu; > > + best_fits_core = fits; > > + } > > } > > > > + if (prefer_idle_cores && best_cpu_core >= 0) > > + return best_cpu_core; > > return best_cpu; > > } > > > > @@ -7994,12 +8052,17 @@ static inline bool asym_fits_cpu(unsigned long util, > > unsigned long util_max, > > int cpu) > > { > > - if (sched_asym_cpucap_active()) > > + if (sched_asym_cpucap_active()) { > > /* > > * Return true only if the cpu fully fits the task requirements > > * which include the utilization and the performance hints. > > + * > > + * When SMT is active, also require that the core has no busy > > + * siblings. > > */ > > - return (util_fits_cpu(util, util_min, util_max, cpu) > 0); > > + return (!sched_smt_active() || is_core_idle(cpu)) && > > + (util_fits_cpu(util, util_min, util_max, cpu) > 0); > > + } > > > > return true; > > } > > @@ -8097,8 +8160,9 @@ static int select_idle_sibling(struct task_struct *p, int prev, int target) > > * capacity path. > > */ > > if (sd) { > > - i = select_idle_capacity(p, sd, target); > > - return ((unsigned)i < nr_cpumask_bits) ? i : target; > > + i = select_idle_capacity(p, sd, target, > > + sched_smt_active() && test_idle_cores(target)); > > Move "sched_smt_active() && test_idle_cores(target)" inside > select_idle_capacity(). I don't see the benefit of making it a > parameter > or use has_idle_core for the parameter like other smt related function And also makes sense. > > > > + return ((unsigned int)i < nr_cpumask_bits) ? i : target; > > } > > } > > > > -- > > 2.53.0 > > Thanks, -Andrea